From: Marius Storm-Olsen <marius@storm-olsen•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Johannes.Schindelin@gmx•de, msysgit@googlegroups•com,
git@vger•kernel.org, lznuaa@gmail•com
Subject: Re: [PATCH 08/17] Test for WIN32 instead of __MINGW32_
Date: Mon, 14 Sep 2009 21:42:32 +0200 [thread overview]
Message-ID: <4AAE9CA8.1070900@gmail.com> (raw)
In-Reply-To: <7v1vm9cohd.fsf@alter.siamese.dyndns.org>
Junio C Hamano said the following on 14.09.2009 21:31:
> Marius Storm-Olsen <mstormo@gmail•com> writes:
>
>> From: Frank Li <lznuaa@gmail•com>
>>
>> The code which is conditional on MinGW32 is actually conditional on Windows.
>> Use the WIN32 symbol, which is defined by the MINGW32 and MSVC environments,
>> but not by Cygwin.
>>
>> Signed-off-by: Frank Li <lznuaa@gmail•com>
>> Signed-off-by: Marius Storm-Olsen <mstormo@gmail•com>
>
> The description sounds very sensible; I wish I read this one first, before
> wasting time scratching my head while reading 03/17. Shouldn't that patch
> be squashed into this one?
Heh, yeah, I agree. After patch got updated with suggestions from last
roll, it clearly makes more sense hear now. I'll update tomorrow. Thanks.
--
.marius
next prev parent reply other threads:[~2009-09-14 19:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 13:11 [RFC/PATCH v2 00/17] Build Git with MSVC Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 01/17] Avoid declaration after statement Marius Storm-Olsen
2009-09-14 13:59 ` Alex Riesen
2009-09-14 14:01 ` Marius Storm-Olsen
2009-09-14 14:04 ` Frank Li
2009-09-14 14:10 ` Alex Riesen
2009-09-14 19:00 ` Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 02/17] boolean is a typedef under MSVC, so rename variable to 'i_boolean' Marius Storm-Olsen
2009-09-14 13:41 ` Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 03/17] Define SNPRINTF_SIZE_CORR=1 for Microsoft Visual C++ Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 04/17] Add define guards to compat/win32.h Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 05/17] Change regerror() declaration from K&R style to ANSI C (C89) Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 06/17] mingw.c: Use the O_BINARY flag to open files Marius Storm-Olsen
2009-09-14 19:06 ` [msysGit] " Alexey Borzenkov
2009-09-14 13:11 ` [PATCH 07/17] Fix __stdcall/WINAPI placement and function prototype Marius Storm-Olsen
2009-09-14 20:00 ` Johannes Sixt
2009-09-15 0:24 ` [msysGit] " Johannes Schindelin
2009-09-15 5:59 ` Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 08/17] Test for WIN32 instead of __MINGW32_ Marius Storm-Olsen
2009-09-14 19:31 ` Junio C Hamano
2009-09-14 19:42 ` Marius Storm-Olsen [this message]
2009-09-14 13:11 ` [PATCH 09/17] Add empty header files for MSVC port Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 10/17] Add MinGW header files to build git with MSVC Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 11/17] Add platform files for MSVC porting Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 12/17] Make usage of windows.h lean and mean Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 13/17] Define strncasecmp as _strnicmp for MSVC Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 14/17] Add ftruncate implementation " Marius Storm-Olsen
2009-09-14 14:18 ` Alex Riesen
2009-09-14 19:03 ` Marius Storm-Olsen
2009-09-14 19:48 ` Junio C Hamano
2009-09-14 13:11 ` [PATCH 15/17] Add MSVC to Makefile Marius Storm-Olsen
2009-09-14 14:06 ` Alex Riesen
2009-09-14 19:09 ` Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 16/17] Add README for MSVC build Marius Storm-Olsen
2009-09-14 13:11 ` [PATCH 17/17] Add scripts to generate projects for other buildsystems (MSVC vcproj, QMake) Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAE9CA8.1070900@gmail.com \
--to=marius@storm-olsen$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=lznuaa@gmail$(echo .)com \
--cc=msysgit@googlegroups$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox