From: Jens Lehmann <Jens.Lehmann@web•de>
To: Junio C Hamano <gitster@pobox•com>, Lars Hjemli <hjemli@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH RESEND] git submodule add: make the <path> parameter optional
Date: Sun, 04 Oct 2009 19:51:36 +0200 [thread overview]
Message-ID: <4AC8E0A8.4000901@web.de> (raw)
In-Reply-To: <7vbpl2srw9.fsf@alter.siamese.dyndns.org>
Junio C Hamano schrieb:
> Jens Lehmann <Jens.Lehmann@web•de> writes:
>
>> When <path> is not given, use the "humanish" part of the source repository
>> instead.
>>
>> Signed-off-by: Jens Lehmann <Jens.Lehmann@web•de>
>> ---
>>
>> With this patch, git submodule add behaves like git clone in this respect.
>>
>> Didn't get a response the last weeks, so here is a resend.
>>
>>
>> Documentation/git-submodule.txt | 8 ++++++--
>> git-submodule.sh | 7 ++++++-
>> t/t7400-submodule-basic.sh | 16 ++++++++++++++++
>> 3 files changed, 28 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
>> index 5ccdd18..4ef70c4 100644
>> --- a/Documentation/git-submodule.txt
>> +++ b/Documentation/git-submodule.txt
>> @@ -10,7 +10,7 @@ SYNOPSIS
>> --------
>> [verse]
>> 'git submodule' [--quiet] add [-b branch]
>> - [--reference <repository>] [--] <repository> <path>
>> + [--reference <repository>] [--] <repository> [<path>]
>> 'git submodule' [--quiet] status [--cached] [--recursive] [--] [<path>...]
>> 'git submodule' [--quiet] init [--] [<path>...]
>> 'git submodule' [--quiet] update [--init] [-N|--no-fetch] [--rebase]
>> @@ -69,7 +69,11 @@ add::
>> to the changeset to be committed next to the current
>> project: the current project is termed the "superproject".
>> +
>> -This requires two arguments: <repository> and <path>.
>> +This requires at least one argument: <repository>. The optional
>> +argument <path> is the relative location for the cloned submodule
>> +to exist in the superproject. If <path> is not given, the
>> +"humanish" part of the source repository is used ("repo" for
>> +"/path/to/repo.git" and "foo" for "host.xz:foo/.git").
>
> I do not know if this is useful in practice nor even desired. Comments?
As nobody commented until now, i'll explain my motivation for this patch.
When adding submodules i was surprised to find that i had to explicitly
provide the pathname even though it could be easily generated from the
reponame as git clone does it. And i see git clone and git submodule add
as related commands from a users perspective, they both connect a remote
repo to a working directory.
IMHO this patch makes the ui more consistent and doesn't break existing
setups or scripts. And it is really useful because i don't do typos in
the pathname anymore ;-)
Jens
next prev parent reply other threads:[~2009-10-04 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 15:10 [PATCH RESEND] git submodule add: make the <path> parameter optional Jens Lehmann
2009-09-22 19:25 ` Junio C Hamano
2009-10-04 17:51 ` Jens Lehmann [this message]
2009-10-04 21:05 ` Johannes Schindelin
2009-10-05 1:31 ` Junio C Hamano
2009-10-05 9:16 ` Johannes Schindelin
2009-10-05 10:28 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC8E0A8.4000901@web.de \
--to=jens.lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=hjemli@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox