From: "J.H." <warthog19@eaglescrag•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: Sylvain Rabot <sylvain@abstraction•fr>, git <git@vger•kernel.org>,
Jakub Narebski <jnareb@gmail•com>
Subject: Re: Make Gitweb behave like Apache mod_userdir
Date: Tue, 17 Nov 2009 16:00:26 -0800 [thread overview]
Message-ID: <4B03391A.90808@eaglescrag.net> (raw)
In-Reply-To: <7vskccaf4q.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> "J.H." <warthog19@eaglescrag•net> writes:
>
>> For starters I think overriding the /~<user> (specifically the ~ here)
>> is going to be a bad idea no matter what you do and gives the wrong
>> impression about what / how the request is being responded to. You
>> might want to try and pick a different delimiter or re-work the rule
>> so that you could have something like:
>>
>> http://git.kernel.org/<gitweb urls>
>> http://git.kernel.org/user/<gitweb urls>
>
> I am not objecting but showing my ignorance, but why is it a bad idea to
> allow
>
> http://git.kernel.org/~junio/git.git
>
> to map to /home/junio/pubilic_git/git.git when
>
> http://www.kernel.org/~junio/index.html
>
> maps to /home/junio/public_html/index.html already?
I'm not objecting to the mapping, I'm objecting to the use of the ~
specifically, since that's the default for mod_userdir - it's more or
less a race condition waiting to happen with respect to does mod_rewrite
get to and process it first or does mod_userdir.
Case in point should:
assuming that www.example.com (to get away from the specifics of
kernel.org) is running gitweb but you also wanted to allow users to show
their ~/public_html directories then
http://www.example.org/~junio/
could be ambiguous as to what should / is servicing the url.
Now in reality it should work because of how apache is setup, but I
would argue it's a bad practice to overload the '~' designator like that
for use in gitweb specifically.
If you have mod_userdir disabled / not available this isn't an issue,
but making that assumption might be a bad idea.
- John 'Warthog9' Hawley
next prev parent reply other threads:[~2009-11-18 0:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 10:04 Make Gitweb behave like Apache mod_userdir Sylvain Rabot
2009-11-15 21:03 ` Junio C Hamano
2009-11-17 13:58 ` Jakub Narebski
2009-11-17 15:51 ` Sylvain Rabot
2009-11-17 18:12 ` Jakub Narebski
2009-11-17 19:56 ` Sylvain Rabot
2009-11-17 20:15 ` Junio C Hamano
2009-11-17 20:24 ` Sylvain Rabot
2009-11-17 22:10 ` Junio C Hamano
2009-11-17 22:54 ` Sylvain Rabot
2009-11-17 23:40 ` Junio C Hamano
2009-11-17 23:52 ` J.H.
2009-11-17 22:59 ` J.H.
2009-11-17 23:46 ` Junio C Hamano
2009-11-17 23:59 ` J.H.
2009-11-18 0:14 ` Junio C Hamano
2009-11-18 0:00 ` J.H. [this message]
2009-11-18 0:16 ` Sylvain Rabot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B03391A.90808@eaglescrag.net \
--to=warthog19@eaglescrag$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jnareb@gmail$(echo .)com \
--cc=sylvain@abstraction$(echo .)fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox