Subject: Re: [PATCH 1/6] stg mail: Refactor __send_message and friends

From: Karl Wiberg <[email-masked]>
Date: Sun, 29 Nov 2009 10:13:44 +0100

Alex Chiang wrote:

> Instead of passing all the various smtp* args to __send_message
> individually, let's just pass the options list instead.

Looks good.

> +    if (smtppassword and not smtpuser):
> +        raise CmdException, 'SMTP password supplied, username needed'
> +    if (smtpusetls and not smtpuser):
> +        raise CmdException, 'SMTP over TLS requested, username needed'

Python style nit: Use "raise Exception('message')" in new code. (And
yes, I know you just moved these lines around.)

-- 
Karl Wiberg, [email-masked]
    subrabbit.wordpress.com
    www.treskal.com/kalle