From: Johannes Sixt <j6t@kdbg•org>
To: Ilari Liusvaara <ilari.liusvaara@elisanet•fi>
Cc: git@vger•kernel.org
Subject: Re: [updated patch v3 2/2] Improve transport helper exec failure reporting
Date: Thu, 31 Dec 2009 20:05:46 +0100 [thread overview]
Message-ID: <4B3CF60A.4050100@kdbg.org> (raw)
In-Reply-To: <1262284003-1417-3-git-send-email-ilari.liusvaara@elisanet.fi>
Ilari Liusvaara schrieb:
> + helper->silent_exec_failure = 1;
> + if (start_command(helper)) {
> + if (errno == ENOENT)
> + die("Unable to find remote helper for \"%s\"",
> + data->name);
> + else
> + die_errno("Unable to run helper %s", helper->argv[0]);
When you fix your implementation of start_command() to follow
Documentation/technical/api-run-command.txt, the error message in the else
branch is not needed anymore (and then you can ask yourself whether you
really want to issue your own error message in the case of ENOENT).
-- Hannes
prev parent reply other threads:[~2009-12-31 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 18:26 [updated patch v3 0/2] Imporve remote helpers exec failure reporting Ilari Liusvaara
2009-12-31 18:26 ` [updated patch v3 1/2] Report exec errors from run-command Ilari Liusvaara
2009-12-31 19:03 ` Johannes Sixt
2010-01-05 5:11 ` Junio C Hamano
2009-12-31 18:26 ` [updated patch v3 2/2] Improve transport helper exec failure reporting Ilari Liusvaara
2009-12-31 19:05 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3CF60A.4050100@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=ilari.liusvaara@elisanet$(echo .)fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox