From: Michael J Gruber <git@drmicha•warpmail.net>
To: Andreas Gruenbacher <agruen@suse•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/3] base85: No need to initialize the decode table in encode_85
Date: Fri, 08 Jan 2010 16:46:41 +0100 [thread overview]
Message-ID: <4B475361.60506@drmicha.warpmail.net> (raw)
In-Reply-To: <1262958000-27181-2-git-send-email-agruen@suse.de>
Andreas Gruenbacher venit, vidit, dixit 08.01.2010 14:39:
> Signed-off-by: Andreas Gruenbacher <agruen@suse•de>
> ---
For the less informed it may be worthwhile to have an explanation in the
commit message why encode_85() does not need to initialize the table. (I
strongly suspect it's a matter of de vs. en, i.e. "because it only
encodes but does not decode."...)
> base85.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/base85.c b/base85.c
> index 1d165d9..7204ce2 100644
> --- a/base85.c
> +++ b/base85.c
> @@ -84,8 +84,6 @@ int decode_85(char *dst, const char *buffer, int len)
>
> void encode_85(char *buf, const unsigned char *data, int bytes)
> {
> - prep_base85();
> -
> say("encode 85");
> while (bytes) {
> unsigned acc = 0;
next prev parent reply other threads:[~2010-01-08 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 14:58 base85: Two tiny fixes Andreas Gruenbacher
2010-01-07 17:58 ` Nicolas Pitre
2010-01-08 13:02 ` Andreas Gruenbacher
2010-01-08 13:39 ` [PATCH 1/3] base85 debug code: Fix length byte calculation Andreas Gruenbacher
2010-01-08 13:39 ` [PATCH 2/3] base85: No need to initialize the decode table in encode_85 Andreas Gruenbacher
2010-01-08 15:46 ` Michael J Gruber [this message]
2010-01-08 15:55 ` Junio C Hamano
2010-01-08 16:17 ` [PATCH] base85: encode85() does not use the decode table Andreas Gruenbacher
2010-01-08 16:22 ` [PATCH] base85: encode_85() " Andreas Gruenbacher
2010-01-08 13:40 ` [PATCH 3/3] base85: Make the code more obvious instead of explaining the non-obvious Andreas Gruenbacher
2010-01-08 23:15 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B475361.60506@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=agruen@suse$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox