Subject: Re: [PATCH 09/18] t3404: Test the commit count in commit messages generated by "rebase -i"

From: Johannes Sixt <[email-masked]>
Date: Thu, 14 Jan 2010 08:44:54 +0100

Michael Haggerty schrieb:
> +	test -z "$EXPECT_HEADER_COUNT" ||
> +		test "$EXPECT_HEADER_COUNT" = $(sed -n '1s/^# This is a combination of \(.*\) commits\./\1/p' < "$1") ||
> +		exit

Is an empty $EXPECT_HEADER_COUNT an error? I suppose it isn't; therefore,
you must put the second 'test' and the 'exit' in a brace group.

You should also put the $(sed) in double-quotes.

-- Hannes