From: Pal-Kristian Engstad <pal_engstad@naughtydog•com>
To: Simon Hausmann <simon@lst•de>, Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: [PATCH 3/3] git-p4: improve submit performance on new P4 servers
Date: Thu, 21 Jan 2010 18:06:00 -0800 [thread overview]
Message-ID: <4B590808.6010206@naughtydog.com> (raw)
Improve git-p4 submit performance on newer (from 2009.2) Perforce
servers by changing "p4 diff -du" to "p4 diff -dub". This change is
harmless since the output is only used for display purposes.
Signed-off-by: Pal-Kristian Engstad <pal_engstad@naughtydog•com>
---
contrib/fast-import/git-p4 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index ab538b3..ec26cac 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -715,7 +715,7 @@ class P4Submit(Command):
submitTemplate = self.prepareLogMessage(template, logMessage)
if os.environ.has_key("P4DIFF"):
del(os.environ["P4DIFF"])
- diff = p4_read_pipe("diff -du ...")
+ diff = p4_read_pipe("diff -dub ...")
newdiff = ""
for newFile in filesToAdd:
--
1.6.5.2.6.gc3c1e.dirty
next reply other threads:[~2010-01-22 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 2:06 Pal-Kristian Engstad [this message]
2010-01-22 2:49 ` [PATCH 3/3] git-p4: improve submit performance on new P4 servers Nicolas Pitre
2010-01-22 2:58 ` Pal-Kristian Engstad
2010-01-22 3:59 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B590808.6010206@naughtydog.com \
--to=pal_engstad@naughtydog$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=simon@lst$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox