Subject: Re: [PATCH 3/3] git-p4: improve submit performance on new P4 servers

From: Pal-Kristian Engstad <[email-masked]>
Date: Thu, 21 Jan 2010 18:58:29 -0800

Nicolas Pitre wrote:
> On Thu, 21 Jan 2010, Pal-Kristian Engstad wrote:
> 
>> Improve git-p4 submit performance on newer (from 2009.2) Perforce
>> servers by changing "p4 diff -du" to "p4 diff -dub". This change is
>> harmless since the output is only used for display purposes.
>>
>> Signed-off-by: Pal-Kristian Engstad <[email-masked]>
> 
> Why is the b flag impacting performance?

That's a very good question. The release notes say that they've been 
changing how 'p4 diff -du' works, but the net effect of it all is that
it stats all files in the whole working set. For large projects, this
takes forever. We say pauses of 3 minutes per submit...

> And even if for display purposes, why might you wish not to see 
> differences in whitespace changes?

That's a good point, but what alternative is there?

PKE
-- 
Pål-Kristian Engstad ([email-masked]), 
Lead Graphics & Engine Programmer,
Naughty Dog, Inc., 1601 Cloverfield Blvd, 6000 North,
Santa Monica, CA 90404, USA. Ph.: (310) 633-9112.

"Emacs would be a far better OS if it was shipped with 
 a halfway-decent text editor." -- Slashdot, Dec 13. 2005.