From: Pal-Kristian Engstad <pal_engstad@naughtydog•com>
To: Nicolas Pitre <nico@fluxnic•net>
Cc: Simon Hausmann <simon@lst•de>, Junio C Hamano <gitster@pobox•com>,
"git@vger•kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH 1/3] git-p4: default submit to use rename detection
Date: Thu, 21 Jan 2010 19:01:30 -0800 [thread overview]
Message-ID: <4B59150A.8000002@naughtydog.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1001212139540.1726@xanadu.home>
Nicolas Pitre wrote:
> On Thu, 21 Jan 2010, Pal-Kristian Engstad wrote:
>
>> Enable git's rename detection by default. This is needed to preserve
>> Perforce's history.
>>
>> Removed the '-M' flag and added a '--no-detect' flag to preserve the
>> old behavior.
>
> You should keep the -M flag, even if it ends up doing nothing, for
> backward compatibility. And --no-detect is really a bad flag name.
> Maybe --no-detect-renames instead?
I'm not sure if git-p4 wants to keep backwards compatibility. I doubt there's
many scripts out there that calls git-p4, but Simon should decide.
I have no problem with the --no-detect-renames flag, though.
PKE.
--
Pål-Kristian Engstad (engstad@naughtydog•com),
Lead Graphics & Engine Programmer,
Naughty Dog, Inc., 1601 Cloverfield Blvd, 6000 North,
Santa Monica, CA 90404, USA. Ph.: (310) 633-9112.
"Emacs would be a far better OS if it was shipped with
a halfway-decent text editor." -- Slashdot, Dec 13. 2005.
prev parent reply other threads:[~2010-01-22 3:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 2:03 [PATCH 1/3] git-p4: default submit to use rename detection Pal-Kristian Engstad
2010-01-22 2:42 ` Nicolas Pitre
2010-01-22 3:01 ` Pal-Kristian Engstad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B59150A.8000002@naughtydog.com \
--to=pal_engstad@naughtydog$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=nico@fluxnic$(echo .)net \
--cc=simon@lst$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox