From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Sebastian Schuberth <sschuberth@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
Johannes Sixt <j.sixt@viscovery•net>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator
Date: Fri, 22 Jan 2010 19:40:42 +0000 [thread overview]
Message-ID: <4B59FF3A.5080502@ramsay1.demon.co.uk> (raw)
In-Reply-To: <4B5789AD.2080807@gmail.com>
Sebastian Schuberth wrote:
> On 20.01.2010 20:23, Ramsay Jones wrote:
>
> > '-o' or connective. This resulted in the buildsystem generator
> > mistaking the conditional 'rm' for a linker command. In order
>
> Thanks for spotting the cause of this! Some comments:
>
> 1. How about deleting lines 183-185 in same run? That commented out
> code, too, is missing the escapes for the pipes that Pete mentioned anyway.
>
> -# } elsif ($text =~ /^test / && $text =~ /|| rm -f /) {
> -# # commands removing executables, if they exist
> -#
OK, will do.
>
> 2. Couldn't we reduce the test to just
>
> + if ($text =~ /^test /) {
> + # options to test may be mistaken for linker options
> + next;
> + }
> +
Yes, good idea. I will send a new version of the patch soon.
Thanks!
ATB,
Ramsay Jones
prev parent reply other threads:[~2010-01-22 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 19:23 [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator Ramsay Jones
2010-01-20 20:57 ` Pete Harlan
2010-01-22 18:58 ` Ramsay Jones
2010-01-20 22:54 ` Sebastian Schuberth
2010-01-22 19:40 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B59FF3A.5080502@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j.sixt@viscovery$(echo .)net \
--cc=sschuberth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox