Subject: Re: [PATCH] Prompt for a username when an HTTP request 401s

From: René Scharfe <[email-masked]>
Date: Fri, 19 Mar 2010 00:53:32 +0100

Am 18.03.2010 20:03, schrieb Shawn O. Pearce:
> Scott Chacon <[email-masked]> wrote:
>> +static void get_http_user_name()
>> +{
>> +	user_name = xstrdup(getpass("Username: "));
> 
> Why are we getting the username via a password prompt where echo
> has been disabled?  Traditionally a username field is obtained as
> echoed input.
> 
> Also, this method shouldn't be named get_*() if its returning void.
> Sounds far to funny.  init_http_user_name()?  prompt_for_user_name()?

Or inline the one-liner at its single call-site?

René