From: Andreas Ericsson <ae@op5•se>
To: Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu•com>
Cc: Junio C Hamano <gitster@pobox•com>,
Andreas Schwab <schwab@linux-m68k•org>,
Giedrius Slavinskas <giedrius.slavinskas@gmail•com>,
git@vger•kernel.org
Subject: Re: git fast-import crashes importing commits with more than one author
Date: Mon, 03 May 2010 10:59:17 +0200 [thread overview]
Message-ID: <4BDE9065.5030500@op5.se> (raw)
In-Reply-To: <y2m86ecb3c71005011028t7f581ce7t98256aa8f8bbb0bf@mail.gmail.com>
On 05/01/2010 07:28 PM, Dmitrijs Ledkovs wrote:
> On 1 May 2010 18:19, Junio C Hamano<gitster@pobox•com> wrote:
>> Dmitrijs Ledkovs<dmitrij.ledkov@ubuntu•com> writes:
>>
>>> On 1 May 2010 17:36, Andreas Schwab<schwab@linux-m68k•org> wrote:
>>>> Giedrius Slavinskas<giedrius.slavinskas@gmail•com> writes:
>>>>
>>>>> git fast-import does not support commits with more than one author. I
>>>>> try to import bzr repository and it crashes.
>>>>
>>>> You can find a patch here:
>>>> <http://bazaar.launchpad.net/~schwab-linux-m68k/bzr-fastimport/fastimport.dev/revision/262>
>>>>
>>>> Andreas.
>>>
>>> Although this is fine shouldn't we put the additional authors to the
>>> signed-off: lines in the git commit message?
>>
>> If an author didn't sign-off in the log message, a tool shouldn't add it
>> automatically. Doing so makes S-o-b meaningless.
>>
>
> Fair enough. I'm justing thinking on how to support round-tripping to
> bzr with import/export cause there are a few other properties bzr
> needs to recreate identical repository. Is it more appropriate for the
> marks format revision (bzr side of it)?
Add
Co-authored-by: Some One <some.one@example•foo>
and parse that when sending back to bzr. That way you get attribution
properly in both tools, in a way.
--
Andreas Ericsson andreas.ericsson@op5•se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
prev parent reply other threads:[~2010-05-03 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 15:43 git fast-import crashes importing commits with more than one author Giedrius Slavinskas
2010-05-01 16:36 ` Andreas Schwab
2010-05-01 16:47 ` Dmitrijs Ledkovs
2010-05-01 17:19 ` Junio C Hamano
2010-05-01 17:28 ` Dmitrijs Ledkovs
2010-05-03 8:59 ` Andreas Ericsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDE9065.5030500@op5.se \
--to=ae@op5$(echo .)se \
--cc=dmitrij.ledkov@ubuntu$(echo .)com \
--cc=giedrius.slavinskas@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=schwab@linux-m68k$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox