From: Andreas Ericsson <ae@op5•se>
To: Ilari Liusvaara <ilari.liusvaara@elisanet•fi>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/3] git over TLS (gits://) support (part 2)
Date: Mon, 03 May 2010 11:44:04 +0200 [thread overview]
Message-ID: <4BDE9AE4.9010908@op5.se> (raw)
In-Reply-To: <1272733791-11341-3-git-send-email-ilari.liusvaara@elisanet.fi>
On 05/01/2010 07:09 PM, Ilari Liusvaara wrote:
A monster-patch, if ever I saw one, yet without a sensible commit message.
What is it this patch actually does?
> +#include "base64.h"
> +#ifdef USE_COMPAT_H
> +#include "compat.h"
> +#else
> +#include "git-compat-util.h"
> +#endif
> +
This would be better moved to compat.h, so the entire file is excluded
and git-compat-util.h is included instead if we're supposed to use that
one. That way you won't have to remember this in every file you use.
> +void encode_uint32(unsigned char *ptr, unsigned long value)
> +{
> + ptr[0] = (unsigned char)(value>> 24);
> + ptr[1] = (unsigned char)(value>> 16);
> + ptr[2] = (unsigned char)(value>> 8);
> + ptr[3] = (unsigned char)(value);
> +}
> +
The second parameter should be uint32_t, obviously.
Reviewing the rest of the patch will have to wait until there's a
proper commit message describing what it's supposed to do, as I
have nowhere near enough time to try to analyze 100k worth of
code to figure out why it's necessary to add it to git.git.
--
Andreas Ericsson andreas.ericsson@op5•se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
next prev parent reply other threads:[~2010-05-03 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 17:09 [PATCH 0/3] git over TLS (gits://) support Ilari Liusvaara
2010-05-01 17:09 ` [PATCH 1/3] git over TLS (gits://) support (part 1) Ilari Liusvaara
2010-05-01 17:09 ` [PATCH 2/3] git over TLS (gits://) support (part 2) Ilari Liusvaara
2010-05-03 9:44 ` Andreas Ericsson [this message]
2010-05-01 17:09 ` [PATCH 3/3] git over TLS (gits://) support (part 3) Ilari Liusvaara
2010-05-01 17:17 ` [PATCH 0/3] git over TLS (gits://) support Sverre Rabbelier
2010-05-03 12:57 ` Tay Ray Chuan
2010-05-03 13:26 ` Michael J Gruber
2010-05-03 17:58 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDE9AE4.9010908@op5.se \
--to=ae@op5$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=ilari.liusvaara@elisanet$(echo .)fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox