From: Michael J Gruber <git@drmicha•warpmail.net>
To: Giuseppe Scrivano <gscrivano@gnu•org>
Cc: git@vger•kernel.org
Subject: Re: [RFC][PATCH] Print the usage string on stdout instead of stderr.
Date: Tue, 25 May 2010 08:46:34 +0200 [thread overview]
Message-ID: <4BFB724A.3020800@drmicha.warpmail.net> (raw)
In-Reply-To: <87pr0lja5n.fsf@gnu.org>
Giuseppe Scrivano venit, vidit, dixit 24.05.2010 22:51:
> Hello Michael,
>
>
> Michael J Gruber <git@drmicha•warpmail.net> writes:
>
>> I haven't checked whether this covers all code paths but other than that
>> it looks OK to me, and the tests pass.
>
> is the patch ready for inclusion?
You're the author, you should know ;)
Note that I can't include your patch. That's up to Junio, and he's been
lagging back for good reasons (as you could read on the list) and is in
the process of keeping up.
I gave you my partial ack'ed-by (see above) and a homework problem to
answer: Have you checked whether this covers all code paths (all
help/usage callers)? If yes then it's a good idea to resend v2 of your
patch as a reply to this thread but with subject "[PATCH v2]..." as it
is hard to find otherwise, and cc to Junio.
Cheers,
Michael
next prev parent reply other threads:[~2010-05-25 6:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 9:48 [RFC][PATCH] Print the usage string on stdout instead of stderr Giuseppe Scrivano
2010-05-17 11:46 ` Michael J Gruber
2010-05-17 12:07 ` Miles Bader
2010-05-17 13:30 ` Michael J Gruber
2010-05-17 13:54 ` Miles Bader
2010-05-17 14:07 ` Giuseppe Scrivano
2010-05-17 14:11 ` Tay Ray Chuan
2010-05-17 12:40 ` Giuseppe Scrivano
2010-05-17 13:30 ` Michael J Gruber
2010-05-17 16:02 ` Giuseppe Scrivano
2010-05-18 9:43 ` Michael J Gruber
2010-05-24 20:51 ` Giuseppe Scrivano
2010-05-25 6:46 ` Michael J Gruber [this message]
2010-05-25 8:40 ` [PATCH v2] " Giuseppe Scrivano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFB724A.3020800@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gscrivano@gnu$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox