From: Michael J Gruber <git@drmicha•warpmail.net>
To: Sam Vilain <sam@vilain•net>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: Apology/Bug report: git-send-email sends everything on Ctrl+C
Date: Wed, 26 May 2010 10:40:08 +0200 [thread overview]
Message-ID: <4BFCDE68.4090909@drmicha.warpmail.net> (raw)
In-Reply-To: <4BFCC4B5.6070408@vilain.net>
Sam Vilain venit, vidit, dixit 26.05.2010 08:50:
> Sam Vilain wrote:
>> Expect a mail storm shortly, sorry folks.
>>
>
> I just had a look at patching git-send-email.perl; but it looks like it
> is checking $? correctly at least since beece9da;
>
> system('sh', '-c', $editor.' "$@"', $editor, $_);
> if (($? & 127) || ($? >> 8)) {
> die("the editor exited uncleanly, aborting everything");
> }
>
> I think I must have actually hit Ctrl-Z, not Ctrl-C. So, it's all my
> fault and I apologize profusely.
>
> Sam
I don't want to make you feel even worse, but could you tell us what
mistake you made so that we can avoid it? Wrong base rev for
format-patch baserev.. and piping directly into send-email?
Michael
prev parent reply other threads:[~2010-05-26 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 6:04 Apology/Bug report: git-send-email sends everything on Ctrl+C Sam Vilain
2010-05-26 6:50 ` Sam Vilain
2010-05-26 8:05 ` Will Palmer
2010-05-26 8:51 ` Sam Vilain
2010-05-26 9:07 ` Sverre Rabbelier
2010-05-26 9:16 ` Michael J Gruber
2010-05-26 9:27 ` Sam Vilain
2010-05-26 8:40 ` Michael J Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFCDE68.4090909@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=sam@vilain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox