From: Jonathan Callen <abcd@gentoo•org>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: git@vger•kernel.org, mduft@gentoo•org, jrnieder@gmail•com
Subject: Re: [PATCH 1/3] Support building on systems without poll(2)
Date: Thu, 27 May 2010 05:13:50 -0400 [thread overview]
Message-ID: <4BFE37CE.9090105@gentoo.org> (raw)
In-Reply-To: <4BFE3286.8070508@drmicha.warpmail.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 05/27/2010 04:51 AM, Michael J Gruber wrote:
> Jonathan Callen venit, vidit, dixit 27.05.2010 10:19:
>> +#ifdef NO_POLL
>> extern int cmd_upload_archive(int argc, const char **argv, const char *prefix);
>> +#endif
>
> Shouldn't this be "ifndef"? makes me wonder how the test compile worked...
>
Yeah, that's a mistake. It should be #ifndef. The test compile worked
because cmd_upload_archive is never called when NO_POLL is defined (and
I didn't test on a system where it wasn't).
- --
Jonathan Callen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCAAGBQJL/jfNAAoJELHSF2kinlg4avYP/3CxgTwg1Wcraf0JLxtg590T
r0VPk/FJfN70kCwch1107qrXFH2Lm5j57R2qcJRPbO4xLg3/7SVDo8uh5srRVBwh
jHV/lVHiDofzAwogv0T1dAd02/WrbpBKM8Wt6sT0fz9Y3yMGPfSuYCazQ0uiH6NA
I/Rk2CcTelNNSo4h8+XRTdMwiEVIehw1zUNX9HhH1SYWastMCgoh2PS+cpeGot+q
IvInTpcOJfOsREXTxjer9zf/GeZsTiEVLgDWZG6Uc0JOEvLTKOqk/BcSeOn4L2zv
lHz14vMT8NS68U/rfPvTjscgczyS2E47XHrvM0+1bswLuNVrilHdzgcnH2rhWFFP
tU/dA6qzzFPvpqLwhXOwxECUsnJ8km5i8oR1914Qwfxr88KVR8syYyDl4eSI3qMg
MbFRTAzRC+4KD1FcGaQ7f7f2J/2Um4wtTb5SrKUJVKk2ROI/2KfBFthI4SbIonOf
NYJp+2XEpc3vbwE6YbiFzXBkP2z/F4fFvorYi8epa1neX7YKF7Hp+U5UJIFBb8de
KMKCoX1ClXjsTQ3B72M29D/o52L67/xcyoPDIfmnjuxeBcrJBO82z8pqMCyF4nh+
xa7mU4rrk6D8ZHxv1uULf8Bqz29Eq6dzzeuNkoV/5plLC2XjWJ2qsMxvZY9dED4h
6SUO3TH9eJJW6eAZG9bB
=RkSh
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-05-27 9:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 8:19 [PATCH 0/3] Interix support Jonathan Callen
2010-05-27 8:19 ` [PATCH 1/3] Support building on systems without poll(2) Jonathan Callen
2010-05-27 8:43 ` Sverre Rabbelier
2010-05-27 13:02 ` Jeff King
2010-05-27 8:51 ` Michael J Gruber
2010-05-27 9:13 ` Jonathan Callen [this message]
2010-05-27 10:10 ` [PATCH] compat: Add another rudimentary poll() emulation Jonathan Nieder
2010-05-27 11:00 ` Erik Faye-Lund
2010-05-27 11:39 ` Marko Kreen
2010-05-27 12:00 ` Erik Faye-Lund
2010-05-27 12:36 ` Marko Kreen
2010-05-27 12:57 ` Erik Faye-Lund
2010-05-27 13:43 ` [msysGit] " Albert Dvornik
2010-05-30 7:44 ` Paolo Bonzini
2010-05-27 13:06 ` Erik Faye-Lund
2010-05-27 13:29 ` Marko Kreen
2010-05-27 13:46 ` Erik Faye-Lund
2010-05-27 13:58 ` Marko Kreen
2010-05-27 14:06 ` Erik Faye-Lund
2010-05-27 14:11 ` Marko Kreen
2010-05-27 14:15 ` Erik Faye-Lund
2010-05-27 14:32 ` Marko Kreen
2010-05-27 14:44 ` Erik Faye-Lund
2010-05-27 15:17 ` Peter Kjellerstedt
2010-05-27 14:14 ` [msysGit] " Albert Dvornik
2010-05-27 14:05 ` Albert Dvornik
2010-05-30 0:37 ` [PATCH v2] " Jonathan Nieder
2010-05-30 19:19 ` Johannes Sixt
2010-05-30 20:40 ` Jonathan Nieder
2010-05-30 22:39 ` Joshua Juran
2010-05-31 3:19 ` Mac OS 9 (Lamp) port Jonathan Nieder
2010-05-31 4:35 ` Joshua Juran
2010-05-31 5:49 ` Jonathan Nieder
2010-05-31 12:12 ` [PATCH v2] compat: Add another rudimentary poll() emulation Albert Dvornik
2010-05-31 12:46 ` Jonathan Nieder
2010-05-31 13:10 ` Albert Dvornik
2010-05-27 8:19 ` [PATCH 2/3] Support building without inttypes.h Jonathan Callen
2010-05-27 8:19 ` [PATCH 3/3] Add Interix support Jonathan Callen
2010-05-28 2:11 ` [PATCH 0/3] " Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFE37CE.9090105@gentoo.org \
--to=abcd@gentoo$(echo .)org \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=mduft@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox