Subject: Re: [PATCH/RFC v3 6/7] gettext: Basic sanity tests for Git's Gettext support

From: Johannes Sixt <[email-masked]>
Date: Wed, 02 Jun 2010 08:32:47 +0200

[When you resend the series in such a manner that you collect a Cc list
manually, please do *not* include me. I'm not interested in this series.]

Am 6/2/2010 1:39, schrieb Ævar Arnfjörð Bjarmason:
> +test_expect_success 'sanity: $TEXTDOMAIN is git' '
> +	test $TEXTDOMAIN = "git"
> +'
> +
> +test_expect_success 'sanity: $TEXTDOMAINDIR exists' '
> +	test -d $TEXTDOMAINDIR 
> +'
> +
> +test_expect_success 'sanity: Icelandic locale was compiled' '
> +    test -f $TEXTDOMAINDIR/is/LC_MESSAGES/git.mo
> +'

3 times: put "$foo" in double-quotes.

> +test_expect_success 'sanity: gettext(unknown) is passed through' '
> +    gettext "" > expect &&
> +    > actual &&
> +    test_cmp expect actual &&
> +    printf "This is not a translation string"  > expect
> +	gettext "This is not a translation string" > actual &&

Strange indentation and you break the && chain.

-- Hannes