Subject: Re: [PATCH 1/2] format-patch: Add a signature option (--signature)

From: Stephen Boyd <[email-masked]>
Date: Tue, 15 Jun 2010 21:31:42 -0700

On 06/15/2010 10:05 AM, Junio C Hamano wrote:
> Stephen Boyd <[email-masked]> write
>> @@ -180,6 +180,12 @@ will want to ensure that threading is disabled for `git send-email`.
>>  	containing the shortlog and the overall diffstat.  You can
>>  	fill in a description in the file before sending it out.
>>  
>> +--signature=<signature>::
>> +	Add a signature to each patch and, if --cover-letter is specified,
>> +	the cover letter. Per RFC 3676 the signature is separated from the
>> +	body by '-- '.
>
> Wouldn't "Add a signature to each message produced" be easier to understand?
> Also perhaps s/body by '-- '/& a line with '-- ' on it/?
>
> Don't we want either an extra header to this entry ("--no-signature::")
> and advertise it as a way to disable signature generation?

Both sound good.

>
>  (3) there is no way to say "no signature, ever" in the configuration.
>
> Perhaps we would want to do this instead?
>
>         static void print_signature(void)
>         {
>                 if (signature && *signature)
>                         printf("-- \n%s\n\n", signature);
>         }

Sounds good too. It's not entirely obvious that format.signature=""
means no signature ever, but that's where documentation steps in I guess.