From: Mark Levedahl <mlevedahl@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, peff@peff•net, jsixt@viscovery•net,
spearce@spearce•org
Subject: Re: [PATCH 2/2 v2] git-gui - provide commit base to the hooks/pre-commit script
Date: Fri, 18 Jun 2010 22:59:20 -0400 [thread overview]
Message-ID: <4C1C3288.5000308@gmail.com> (raw)
In-Reply-To: <1275965763-18940-2-git-send-email-mlevedahl@gmail.com>
On 06/07/2010 10:56 PM, Mark Levedahl wrote:
> If hooks/pre-commit acts based upon the changes to be checked in
> rather than just the resulting content, the script needs to know which
> commit to use. For a normal commit, this is HEAD, but when amending this
> is HEAD~1. So, this modifies commit.tcl to pass $1 as HEAD|HEAD~1 depending
> upon the commit type. Existing scripts are unaffected as they did not
> expect any argument so will silently ignore this extra bit of info.
>
> Signed-off-by: Mark Levedahl<mlevedahl@gmail•com>
>
Given the discussion on the first series (starting
with)<1275759590-16342-1-git-send-email-mlevedahl@gmail•com>, and the
absence of objection to v2, I presume this sequence is ok?
Mark
next prev parent reply other threads:[~2010-06-19 2:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 2:56 [PATCH 1/2 v2] commit.c - provide base commit to the hooks/pre-commit script Mark Levedahl
2010-06-08 2:56 ` [PATCH 2/2 v2] git-gui - provide commit base " Mark Levedahl
2010-06-19 2:59 ` Mark Levedahl [this message]
2010-06-21 4:54 ` Junio C Hamano
2010-06-21 5:00 ` Jeff King
2010-06-22 1:07 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1C3288.5000308@gmail.com \
--to=mlevedahl@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jsixt@viscovery$(echo .)net \
--cc=peff@peff$(echo .)net \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox