From: Michael J Gruber <git@drmicha•warpmail.net>
To: Steven Rostedt <rostedt@goodmis•org>
Cc: "Darren Hart" <darren@dvhart•com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
git@vger•kernel.org
Subject: Re: [PATCH] Documentation/git-clone: describe --mirror more verbose
Date: Mon, 04 Oct 2010 09:25:17 +0200 [thread overview]
Message-ID: <4CA9815D.3040801@drmicha.warpmail.net> (raw)
In-Reply-To: <1285967766.6750.2.camel@gandalf.stny.rr.com>
Steven Rostedt venit, vidit, dixit 01.10.2010 23:16:
> On Fri, 2010-10-01 at 13:18 -0700, Darren Hart wrote:
>> 2010/10/1 Uwe Kleine-König <u.kleine-koenig@pengutronix•de>:
>>> Some people in #linux-rt claimed that you cannot define "--mirror" with
>>> "mirror".
>>>
I'd say "mirror" is a commonly known term for an exact copy. Moreover,
the text below doesn't explain what a mirror is either, only how
"update" behaves in it.
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix•de>
>>
>> Acked-by: Darren 'Some People' Hart <darren@dvhart•com>
>
> Acked-by: Steven Rostedt <rostedt@goodmis•org>
>
> -- Steve
>
>>
>>> ---
>>> Documentation/git-clone.txt | 11 ++++++++++-
>>> 1 files changed, 10 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
>>> index dc7d3d1..5eedfbd 100644
>>> --- a/Documentation/git-clone.txt
>>> +++ b/Documentation/git-clone.txt
>>> @@ -128,7 +128,16 @@ objects from the source repository into a pack in the cloned repository.
>>> configuration variables are created.
>>>
>>> --mirror::
>>> - Set up a mirror of the remote repository. This implies `--bare`.
>>> + Set up a mirror of the remote repository.
>>> + Using
>>> +
>>> + git remote update origin
>>> +
>>> + (or `<name>` instead of `origin` if -o is given) in the resulting
"remote" has no "-o" option. You probably mean the "clone" option, but
the way it's written it refers to the preceding command.
>>> + repository overwrites the local branches without asking.
>>> + This implies `--bare`.
Again, "this" refers to the preceding sentence. But the update behavior
does not imply "--bare". Specifying "--mirror" for "clone" implies "--bare".
>>> + Without --mirror (but with --bare) git remote update doesn't touch any
>>> + branches at all.
That's not true. It just doesn't touch any local branches; it updates
the remote branches, of course.
I'm sorry but I can't consider this patch an improvement.
Michael
next prev parent reply other threads:[~2010-10-04 7:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 20:13 [PATCH] Documentation/git-clone: describe --mirror more verbose Uwe Kleine-König
2010-10-01 20:18 ` Darren Hart
2010-10-01 21:16 ` Steven Rostedt
2010-10-04 7:25 ` Michael J Gruber [this message]
2010-10-04 7:50 ` Uwe Kleine-König
2010-10-04 8:23 ` Michael J Gruber
2010-10-04 8:50 ` Uwe Kleine-König
2010-10-04 9:28 ` Michael J Gruber
2010-10-04 9:51 ` [PATCH v2] " Uwe Kleine-König
2010-10-04 12:47 ` Steven Rostedt
2010-10-04 12:52 ` Michael J Gruber
2010-10-04 14:42 ` Darren Hart
2010-10-04 17:28 ` [PATCH v3] Documentation/git-clone: describe --mirror more verbosely Uwe Kleine-König
2010-10-04 17:29 ` [PATCH] Documentation/git-clone: describe --mirror more verbose Junio C Hamano
2010-10-04 17:39 ` Matthieu Moy
2010-10-04 19:05 ` Darren Hart
2010-10-05 7:01 ` Uwe Kleine-König
2010-10-05 15:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9815D.3040801@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=darren@dvhart$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=rostedt@goodmis$(echo .)org \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox