Subject: Re: [PATCH v3 2/3] Add the 'fetch.recurseSubmodules' config setting

From: Jens Lehmann <[email-masked]>
Date: Thu, 11 Nov 2010 09:14:53 +0100

Am 11.11.2010 01:02, schrieb Jonathan Nieder:
> Jens Lehmann wrote:
> 
>> --- a/t/t5526-fetch-submodules.sh
>> +++ b/t/t5526-fetch-submodules.sh
>> @@ -106,4 +106,40 @@ test_expect_success "--dry-run propagates to submodules" '
>>  	test_cmp expect.err actual.err
>>  '
>>
>> +test_expect_success "recurseSubmodules=true propagates into submodules" '
>> +	add_upstream_commit &&
>> +	(
>> +		cd downstream &&
>> +		git config fetch.recurseSubmodules true
>> +		git fetch >../actual.out 2>../actual.err
>> +	) &&
>> +	test_cmp expect.out actual.out &&
>> +	test_cmp expect.err actual.err
>> +'
> 
> This configuration item is read from .gitmodules, too, right?  Would
> it be easy (or desirable) to make it not read from there?  Either way,
> it would be nice to have a test so the behavior doesn't change without
> anyone noticing.

"fetch.recurseSubmodules" is only read from .git/config. The one read
first from .gitmodules and then from .git/config is the per-submodule
setting "submodule.<name>.fetchRecurseSubmodules" added in 3/3. But
maybe I should add a test that "fetch.recurseSubmodules" also works
when set in the global config ...