From: Michael J Gruber <git@drmicha•warpmail.net>
To: Jakub Narebski <jnareb@gmail•com>
Cc: Jari Aalto <jari.aalto@cante•net>, git@vger•kernel.org
Subject: Re: [PATCH] git-cherry.txt: Change symbol marks in graph.
Date: Thu, 02 Dec 2010 12:05:33 +0100 [thread overview]
Message-ID: <4CF77D7D.90507@drmicha.warpmail.net> (raw)
In-Reply-To: <m31v604nc0.fsf@localhost.localdomain>
Jakub Narebski venit, vidit, dixit 02.12.2010 09:00:
> Jari Aalto <jari.aalto@cante•net> writes:
>
>> From: Jari Aalto <jari.aalto@cante•net>
>>
>> The common commit were marked with a minus sign (-), but that is
>> usually interpreted as something less or substracted. Use natural
>> equal sign (=). Commits that are not in upstream were marked with plus
>> sign (+) but a question mark (?) is visually a litle more striking
>> (erect) in context where all other signs are "flat". It also helps
>> visually impared to see difference between (* ... ?) as opposed to
>> similar signs (* ... +).
>
> Reading comprehension FAIL. The graph in question uses '+' and '-' because
> that is what 'git cherry' *output( uses ('+' included, '-' excluded). They
> are very natural in git-cherry output (diff-like).
Yep, and I so wished that git-cherry had different output that I even
saw a git-cherry patch where there was none...
So, +1 from me if this comes with an actual code patch.
Michael
next prev parent reply other threads:[~2010-12-02 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 5:18 [PATCH] git-cherry.txt: Change symbol marks in graph jari.aalto
2010-12-02 8:00 ` Jakub Narebski
2010-12-02 11:05 ` Michael J Gruber [this message]
2010-12-02 17:25 ` Junio C Hamano
2010-12-02 8:09 ` Michael J Gruber
2010-12-02 12:28 ` [PATCH v2] " Jari Aalto
2010-12-02 15:26 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF77D7D.90507@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=jari.aalto@cante$(echo .)net \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox