Subject: BUG: gitk fails to parse 1.7.4-rc0 version string

From: Mathias Lafeldt <[email-masked]>
Date: Tue, 04 Jan 2011 13:44:54 +0100

Looks like gitk doesn't like the "-rc0" suffix.

$ git --version
git version 1.7.4-rc0

$ gitk
Error in startup script: expected version number but got "1.7.4-rc0"
    while executing
"package vcompare $git_version "1.6.6.2""
    (file "/usr/local/bin/gitk" line 1)

I temporarily fixed it by hard-coding the version string:

diff --git a/gitk-git/gitk b/gitk-git/gitk
index e82c6bf..367446e 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11581,7 +11581,7 @@ if {![info exists have_ttk]} {
 set use_ttk [expr {$have_ttk && $want_ttk}]
 set NS [expr {$use_ttk ? "ttk" : ""}]

-set git_version [join [lrange [split [lindex [exec git version] end] .]
0 2] .]
+set git_version "1.7.4"

 set show_notes {}
 if {[package vcompare $git_version "1.6.6.2"] >= 0} {

-Mathias