From: A Large Angry SCM <gitzilla@gmail•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] t9010: svnadmin can fail even if available
Date: Thu, 06 Jan 2011 13:32:25 -0500 [thread overview]
Message-ID: <4D260AB9.2060406@gmail.com> (raw)
In-Reply-To: <20110106180051.GC11346@burratino>
On 01/06/2011 01:00 PM, Jonathan Nieder wrote:
> If svn is built against one version of SQLite and run against
> another, svnadmin (needlessly) errors out during t9010:
>
> <<< Started new transaction, based on original revision 1
> * adding path : branches ... done.
> * adding path : trunk ... done.
> svnadmin: Couldn't perform atomic initialization
> svnadmin: Couldn't perform atomic initialization
> svnadmin: SQLite compiled for 3.7.4, but running with 3.7.3
>
> Work around this by putting the svn invocations into a single test
> that builds a repo to compare the test-svn-fe result against. This
> test would always pass but only set the new SVNREPO test prereq if svn
> succeeds; and the test using that repo gets an SVNREPO prerequisite so
> it only runs with working svn installations.
>
> This seems like the right thing to, anyway: the test script is meant
> to test the version of git just built, not the installed svn.
>
> As a side effect, earlier tests will run now even if svn is not
> installed. Remove the svn_cmd () helper to decrease the temptation to
> run svn from those tests.
>
> Works-around: http://bugs.debian.org/608925
> Reported-by: A Large Angry SCM<gitzilla@gmail•com>
> Signed-off-by: Jonathan Nieder<jrnieder@gmail•com>
> ---
> Thanks. Does this patch work for you?
$ sh t9010-svn-fe.sh
ok 1 - empty dump
ok 2 - v3 dumps not supported
ok 3 - set up svn repo
ok 4 # skip t9135/svn.dump (missing SVNREPO)
# passed all 4 test(s)
1..4
Rerunning the full test suite now ...
next prev parent reply other threads:[~2011-01-06 18:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 16:04 Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1) A Large Angry SCM
2011-01-06 16:59 ` Jonathan Nieder
2011-01-06 17:20 ` A Large Angry SCM
2011-01-06 18:00 ` [PATCH] t9010: svnadmin can fail even if available Jonathan Nieder
2011-01-06 18:32 ` A Large Angry SCM [this message]
2011-01-06 20:16 ` Junio C Hamano
2011-01-06 20:46 ` Jonathan Nieder
2011-01-07 1:07 ` Junio C Hamano
2011-01-07 1:31 ` Jonathan Nieder
2011-01-07 16:58 ` Ramkumar Ramachandra
2011-01-07 18:54 ` Junio C Hamano
2011-01-06 18:15 ` Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1) Junio C Hamano
2011-01-06 19:06 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D260AB9.2060406@gmail.com \
--to=gitzilla@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox