From: Michael J Gruber <git@drmicha•warpmail.net>
To: Jeff King <peff@peff•net>
Cc: Marco <netuse@lavabit•com>, git@vger•kernel.org
Subject: Re: Why doesn't git commit -a track new files
Date: Fri, 25 Feb 2011 10:03:16 +0100 [thread overview]
Message-ID: <4D677054.9050908@drmicha.warpmail.net> (raw)
In-Reply-To: <20110225090126.GA16861@sigill.intra.peff.net>
Jeff King venit, vidit, dixit 25.02.2011 10:01:
> On Fri, Feb 25, 2011 at 09:51:37AM +0100, Michael J Gruber wrote:
>
>>> I assumed that:
>>>
>>> git commit -a <path>
>>>
>>> would behave more like the "git add -u <path>" case; add new stuff to
>>> the index from <path>, and then commit those changes plus whatever was
>>> already in the index.
>>
>> Yes, you're right. I haven't wrapped my brain completely around those
>> mixed cases yet (changes in index + pathspec argument). My aim is that
>>
>> "git commit <addoptions> <commitoptions> [<pathspec>]"
>>
>> would be equivalent to (the atomic version of)
>>
>> "git add <addoptions> [<pathspec>] && git commit <commitoptions>"
>>
>> and that is difficult because currently, pathspecs are "limiting" for
>> commit and "additive" for add without -u. I mean, I don't want to break
>> anything, at least not before 1.8.0..
>
> I don't think there is any breakage with "-a" (or "-A") there, as you
> are adding a new mode of operation that currently doesn't work (e.g.,
> right now "git commit -a foo" will die). The only thing that would not
> work is trying to make:
>
> git add <path> && git commit
>
> the same as
>
> git commit <path>
>
> But I am not sure that is a good idea anyway. Yes, it is a little
> inconsistent with the other forms, but I think it is generally what you
> want
Very true. I guess that nails our specification.
> (which is why the default for commit with paths switched from "-i"
> to "-o" long ago).
...before my time (or under my radar).
Equivalent options and slightly different defaults should be fine, just
as you explained.
"-i" is implicit for "add" and "-o" is nonsensical/unnecessary (there is
no temp. index for add, but there is reset), so those need not be covered.
Michael
next prev parent reply other threads:[~2011-02-25 9:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 10:22 Why doesn't git commit -a track new files Marco
2011-02-24 14:06 ` Ævar Arnfjörð Bjarmason
2011-02-24 14:09 ` Pascal Obry
2011-02-24 14:20 ` Marco
2011-02-24 15:02 ` Michael J Gruber
2011-02-24 15:49 ` Jeff King
2011-02-24 15:54 ` Michael J Gruber
2011-02-24 16:00 ` Jeff King
2011-02-24 16:01 ` Michael J Gruber
2011-02-24 16:09 ` Jeff King
2011-02-25 8:51 ` Michael J Gruber
2011-02-25 9:01 ` Jeff King
2011-02-25 9:03 ` Michael J Gruber [this message]
2011-02-25 9:09 ` Jeff King
2011-02-24 16:04 ` Matthieu Moy
2011-02-24 16:04 ` Michael J Gruber
2011-02-24 16:47 ` Marco
2011-02-25 4:30 ` Miles Bader
2011-02-25 8:43 ` Michael J Gruber
2011-02-26 6:45 ` Miles Bader
2011-02-24 16:19 ` Marc Weber
2011-02-24 17:27 ` Junio C Hamano
2011-02-24 18:45 ` Marco
2011-02-25 10:15 ` Michael J Gruber
2011-02-25 17:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D677054.9050908@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=netuse@lavabit$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox