From: Michael J Gruber <git@drmicha•warpmail.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
Matthijs Kooijman <matthijs@stdin•nl>
Subject: Re: [PATCH] setup: return correct prefix if worktree is '/'
Date: Fri, 25 Mar 2011 15:17:19 +0100 [thread overview]
Message-ID: <4D8CA3EF.3010403@drmicha.warpmail.net> (raw)
In-Reply-To: <1301060989-7246-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy venit, vidit, dixit 25.03.2011 14:49:
> The same old problem reappears after setup code is reworked. We tend
> to assume there is at least one path component in a path and forget
> that path can be simply '/'.
>
> Reported-by: Matthijs Kooijman <matthijs@stdin•nl>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail•com>
> ---
> cache.h | 2 ++
> path.c | 35 +++++++++++++++++++++++++++++++++++
> setup.c | 5 ++---
> 3 files changed, 39 insertions(+), 3 deletions(-)
>
Wait wait, the bug bisects to
490544b (get_cwd_relative(): do not misinterpret suffix as subdirectory,
2010-05-22)
for me, using
git bisect run sh -c "make || exit 125; cd /etc; GIT_DIR=/tmp/a/.git
~/src/git/git-add fstab || exit 1"
and a repo in /tmp/a/.git with core.worktree set to "/".
The issue is that in get_relative_cwd() of dir.c, "dir" (and maybe
("cwd") may or may not end in "/", so even with dir="/etc/" and
cwd="/etc" we would not recognize we are within the repo. Patch for that
is coming.
Note that by doing something like the above, we can test / without being
root as long as we have files there which we can rely on being readable,
or can rely on /tmp being there.
Michael
next prev parent reply other threads:[~2011-03-25 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 10:02 git-add says 'pathspec did not match any files' for git repository in / Matthijs Kooijman
2011-03-25 12:56 ` Nguyen Thai Ngoc Duy
2011-03-25 13:49 ` [PATCH] setup: return correct prefix if worktree is '/' Nguyễn Thái Ngọc Duy
2011-03-25 14:17 ` Michael J Gruber [this message]
2011-03-25 15:11 ` Nguyen Thai Ngoc Duy
2011-03-25 15:52 ` [PATCH] dir.c: do not trip over difference in "/" Michael J Gruber
2011-03-26 7:59 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8CA3EF.3010403@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=matthijs@stdin$(echo .)nl \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox