From: "J.H." <warthog9@eaglescrag•net>
To: Jakub Narebski <jnareb@gmail•com>
Cc: git@vger•kernel.org, Kevin Cernekee <cernekee@gmail•com>
Subject: Re: [PATCH/RFC 0/3] gitweb: Split gitweb.js, improve JavaScript
Date: Fri, 25 Mar 2011 15:03:22 -0700 [thread overview]
Message-ID: <4D8D112A.5020703@eaglescrag.net> (raw)
In-Reply-To: <1301089586-8534-1-git-send-email-jnareb@gmail.com>
The only thing I would comment on is that we may want to document (for
the build process) a way to force a certain ordering of various files.
Case in point we probably want to force the things like various global
defs (what I'm proposing in the timezone stuff) at the top and let the
function defs go below that.
Other than that this all looks good.
- John 'Warthog9' Hawley
On 03/25/2011 02:46 PM, Jakub Narebski wrote:
> This patch series is inspired by patch by John 'Warthog9' Hawley
>
> [PATCH 1/1] gitweb: javascript ability to adjust time based on timezone
> Message-Id: <1300925335-3212-2-git-send-email-warthog9@eaglescrag•net>
> http://thread.gmane.org/gmane.comp.version-control.git/169384/focus=169882
>
> that added a few new JavaScript files for the new feature that this
> patch implemented.
>
> This is marked as RFC mainly because other patches in series,
> especially the last one fixing bug in gitweb's JavaScript code, should
> be send independently on gitweb.js splitting.
>
> Jakub Narebski (3):
> gitweb: Split JavaScript for maintability; concatenate on build
> gitweb: Update and improve comments in JavaScript files
> gitweb: Fix parsing of negative fractional timezones in JavaScript
>
> .gitignore | 1 +
> gitweb/Makefile | 12 +-
> .../static/{gitweb.js => js/blame_incremental.js} | 216 ++------------------
> gitweb/static/js/common-lib.js | 191 +++++++++++++++++
> gitweb/static/js/detect-javascript.js | 44 ++++
> 5 files changed, 261 insertions(+), 203 deletions(-)
> rename gitweb/static/{gitweb.js => js/blame_incremental.js} (75%)
> create mode 100644 gitweb/static/js/common-lib.js
> create mode 100644 gitweb/static/js/detect-javascript.js
>
next prev parent reply other threads:[~2011-03-25 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 21:46 [PATCH/RFC 0/3] gitweb: Split gitweb.js, improve JavaScript Jakub Narebski
2011-03-25 21:46 ` [PATCH/RFC 1/3] gitweb: Split JavaScript for maintability; concatenate on build Jakub Narebski
2011-03-25 21:46 ` [PATCH/RFC 2/3] gitweb: Update and improve comments in JavaScript files Jakub Narebski
2011-03-25 21:46 ` [PATCH/RFC 3/3] gitweb: Fix parsing of negative fractional timezones in JavaScript Jakub Narebski
2011-03-25 22:03 ` J.H. [this message]
2011-03-26 11:08 ` [PATCH/RFC 0/3] gitweb: Split gitweb.js, improve JavaScript Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8D112A.5020703@eaglescrag.net \
--to=warthog9@eaglescrag$(echo .)net \
--cc=cernekee@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox