From: Johannes Sixt <j.sixt@viscovery•net>
To: Andrew Garber <andrew@andrewgarber•com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Git Mailing List" <git@vger•kernel.org>
Subject: Re: Why can't I use git-bisect to find the first *good* commit?
Date: Mon, 28 Mar 2011 16:40:17 +0200 [thread overview]
Message-ID: <4D909DD1.2050904@viscovery.net> (raw)
In-Reply-To: <AANLkTin1QCda9BV+gND1kcXRTZBF7hj3Chce5OkLX2a9@mail.gmail.com>
Am 3/28/2011 16:29, schrieb Andrew Garber:
>> I'd expect this to work:
>>
>> $ git bisect start
>> $ git bisect good
>> $ git bisect bad HEAD~100
>
> So would I. I think the behavior of git bisect should be changed.
> Right now, it's trying to find the first bad commit. Instead, it
> should be trying to find the first commit where the code's good/bad
> state *changed*. IOW, it should be able to handle both of the
> following cases:
>
> good <--- oldest
> good
> good
> bad <--- the commit we want bisect to find
> bad
> bad <--- newest
>
> bad <--- oldest
> bad
> bad
> good <--- the commit we want bisect to find
> good
> good <--- newest
>
> It shouldn't matter which end we start on, so long as one end gets
> marks good, and the other end gets marked bad.
Define "end" and "other end"! It's not that trivial.
o--o--o--B
/
--o--o--o--o--G
When I have this history and I mark B as bad and G as good, will I now
find the first bad or the first good commit?
-- Hannes
next prev parent reply other threads:[~2011-03-28 14:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 9:32 Why can't I use git-bisect to find the first *good* commit? Ævar Arnfjörð Bjarmason
2011-03-28 10:39 ` Andreas Ericsson
2011-03-28 12:22 ` code.sculptor
2011-03-28 12:58 ` Matthieu Moy
2011-03-28 12:39 ` Vincent van Ravesteijn
2011-03-28 14:04 ` Christian Couder
2011-03-28 14:29 ` Andrew Garber
2011-03-28 14:40 ` Johannes Sixt [this message]
2011-03-28 17:18 ` Andrew Garber
2011-03-28 17:33 ` Matthieu Moy
2011-03-28 17:45 ` Andrew Garber
2011-03-28 17:55 ` Matthieu Moy
2011-03-28 18:12 ` Andrew Garber
2011-03-28 18:23 ` Matthieu Moy
2011-03-28 18:57 ` demerphq
2011-03-28 19:12 ` Andrew Garber
2011-03-28 19:40 ` Matthieu Moy
2011-03-28 20:12 ` Andrew Garber
2011-03-28 20:25 ` Jeff King
2011-03-28 21:25 ` Jeff King
2011-03-28 20:37 ` Matthieu Moy
2011-03-29 10:54 ` Andreas Ericsson
2011-05-22 19:41 ` Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D909DD1.2050904@viscovery.net \
--to=j.sixt@viscovery$(echo .)net \
--cc=andrew@andrewgarber$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox