public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ferry Huberts <mailings@hupie•com>
To: Andreas Ericsson <ae@op5•se>
Cc: git@vger•kernel.org
Subject: Re: git & patterns
Date: Wed, 18 May 2011 15:36:15 +0200	[thread overview]
Message-ID: <4DD3CB4F.6080304@hupie.com> (raw)
In-Reply-To: <4DD3C484.2070102@op5.se>

On 05/18/2011 03:07 PM, Andreas Ericsson wrote:
> On 05/18/2011 12:48 PM, Ferry Huberts wrote:
>> Hi list
>>
>> After reading the manual page for git describe it was not clear to me what
>> kind of pattern the --match option should take. Was it to be
>> a shell pattern (to be expected) or a regular expression pattern?
>>
>> So I dug in the code to find fnmatch: shell pattern.
>>
>> Now my question(s):
>> - could the manual page be update to make this explicit please? (plus
>> other manual pages talking about (shell) patterns)
> 
> Patches welcome.
> 
>> - could git start taking regular expression patterns please?
>>
> 
> I'm not the maintainer, but with my incredible powers of foresight I'll
> take a wild stab at answering in his stead:
> Not with the current argument, no, but introducing '--rematch' or '--rmatch'
> to take a regular expression instead would probably be a welcome patch if
> it's well done.

agreed

> 
> 
>> I'm using the --match option on git describe to generate version
>> information from and matching against a regular expression is soooo much
>> more powerful and allows me to fully define my naming convention while
>> shell patterns do not allow me to do so.
>>
>> Or am I missing something?
>>
> 
> You're not, but we're missing the patch ;)

Will see if I can make some time but I'm pretty busy :-(

Thanks!

> For my own needs, the fnmatch patterns work quite well.
> 

grtz

-- 
Ferry Huberts

  reply	other threads:[~2011-05-18 13:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 10:48 git & patterns Ferry Huberts
2011-05-18 13:07 ` Andreas Ericsson
2011-05-18 13:36   ` Ferry Huberts [this message]
2011-05-18 19:55 ` Junio C Hamano
2011-05-19  6:23   ` Ferry Huberts
2011-05-19  6:40     ` Tim Mazid
2011-05-19  6:43       ` Tim Mazid
2011-05-19  6:46         ` Ferry Huberts
2011-05-19  6:54           ` Tim Mazid
2011-05-19  6:47     ` Junio C Hamano
2011-05-19  6:54       ` Ferry Huberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD3CB4F.6080304@hupie.com \
    --to=mailings@hupie$(echo .)com \
    --cc=ae@op5$(echo .)se \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox