public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Markus Duft <mduft@gentoo•org>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
	git@vger•kernel.org, Tor Arntsen <tor@spacetec•no>,
	Erik Faye-Lund <kusmabite@gmail•com>
Subject: Re: [PATCH 2/2] Include unistd.h.
Date: Mon, 30 May 2011 08:51:01 +0200	[thread overview]
Message-ID: <4DE33E55.6090505@gentoo.org> (raw)
In-Reply-To: <20110526163921.GD24931@elie>

On 05/26/11 18:39, Jonathan Nieder wrote:
> Junio C Hamano wrote:
> 
>> --- a/compat/fnmatch/fnmatch.c
>> +++ b/compat/fnmatch/fnmatch.c
>> @@ -127,6 +127,10 @@ extern char *getenv ();
>>  extern int errno;
>>  # endif
>> +
>> +# ifndef NULL
>> +#  define NULL 0
>> +# endif
> 
> Makes a lot of sense.  This fits well with the style of the rest of
> the file and other projects using glibc fnmatch could reuse the fix
> even if targeting ancient platforms.

I tested, and it works well on interix. Will you commit, or should i prepare a patch?

Thanks
Markus

next prev parent reply	other threads:[~2011-05-30  6:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25 14:15 [PATCH] Interix catch-ups for recent changes/releases mduft
2011-05-25 14:15 ` [PATCH 1/2] Add additional build options for Interix, and remove obsolete ones mduft
2011-05-25 17:51   ` Junio C Hamano
2011-05-26  6:29   ` Markus Duft
2011-05-26 18:06     ` Junio C Hamano
2011-05-25 14:15 ` [PATCH 2/2] Include unistd.h mduft
2011-05-25 18:30   ` Junio C Hamano
2011-05-25 20:37     ` Tor Arntsen
2011-05-25 21:00       ` Junio C Hamano
2011-05-25 21:52     ` Erik Faye-Lund
2011-05-26  2:20   ` Jonathan Nieder
2011-05-26 15:48     ` Junio C Hamano
2011-05-26 16:39       ` Jonathan Nieder
2011-05-30  6:51         ` Markus Duft [this message]
2011-06-15  9:31           ` Markus Duft
2011-06-15  9:48             ` Jonathan Nieder
2011-06-15 11:34               ` [PATCH] Update the Interix default build configuration mduft
2011-05-27  6:27   ` [PATCH 2/2] Include unistd.h Markus Duft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE33E55.6090505@gentoo.org \
    --to=mduft@gentoo$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=kusmabite@gmail$(echo .)com \
    --cc=tor@spacetec$(echo .)no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox