From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Chris Wilson <cwilson@vigilantsw•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Fix config_file file leak.
Date: Tue, 19 Jul 2011 18:28:59 +0100 [thread overview]
Message-ID: <4E25BEDB.6040002@ramsay1.demon.co.uk> (raw)
In-Reply-To: <20110714181948.GA23288@localhost>
Chris Wilson wrote:
> Hi,
>
> We are using Sentry (a C/C++ static analysis tool) to analyze
> git on a nightly basis. Sentry found that a file leak
> was recently introduced in the commit 924aaf3.
Hmmm ..., commit 924aaf3 did *not* introduce a file handle leak.
It would seem that the change in scope of the file handle made it
easier for Sentry to see the *existing* (potential) file handle leak.
no?
Other than that, ...
ATB,
Ramsay Jones
next prev parent reply other threads:[~2011-07-19 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 18:19 [PATCH] Fix config_file file leak Chris Wilson
2011-07-14 18:29 ` Chris Wilson
2011-07-19 17:28 ` Ramsay Jones [this message]
2011-07-20 13:12 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E25BEDB.6040002@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=cwilson@vigilantsw$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox