public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: pascal@obry•net
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/2] On Cygwin support both UNIX and DOS style path-names
Date: Thu, 11 Aug 2011 21:35:39 +0100	[thread overview]
Message-ID: <4E443D1B.60306@ramsay1.demon.co.uk> (raw)
In-Reply-To: <4E419AB3.7090405@obry.net>

Pascal Obry wrote:
> Le 09/08/2011 19:24, Ramsay Jones a écrit :
>> Pascal Obry wrote:
>>> In fact Cygwin supports both, so make Git agree with this.
>>> The failing case is when a file is committed in a sub-dir of the
>>> repository using a log message from a file specified with a DOS
>>> style path-name. To reproduce:
>>>
>>>     $ cd src
>>>     $ git commit -F c:\tmp\log.txt file.c
>>>     fatal: could not read log file 'src/c:\tmp\log.txt': No such file \
>>>     or directory.
>> Hmm, are you using bash or cmd.exe? Using bash I get the following:
> 
> bash.

Ah, OK. The example in your commit message looked odd (ie incorrect) which
made me think that you were probably using cnd.exe, so ...

>>      $ cd src
>>      $ git commut -F c:\tmp\log.txt file.c
>>      fatal: could not read file 'src/c:tmplog.txt': No such file or directory
>>      $
>>
>> Which is what I would expect of (any) posix shell, viz:
>>
>>      $ ls c:\
>>      >  ^C
>>      $ ls c:\\
>>      AUTOEXEC.BAT*            NTDETECT.COM*               WATCOM/       msysgit/
>>      CMPNENTS/                Program Files/              WINDOWS/      msysgit-old/
>>      CONFIG.SYS*              RECYCLER/                   boot.ini*     ntldr*
>>      Documents and Settings/  SUPPORT/                    cygwin/       pagefile.sys
>>      I386/                    SWSTAMP.TXT*                cygwintemp/   ssl/
>>      IO.SYS*                  System Volume Information/  dm/           uname/
>>      MSDOS.SYS*               TOOLSCD/                    dm840/        zlib/
>>      MSOCache/                VALUEADD/                   hiberfil.sys
> 
> Exactly, \\ this is what I have used and this is the bug. Cygwin 
> supports ls c:\\ so should Cygwin/Git. My quoted example was missing the 
> escape \.

 ... could you please correct your commit message. Thanks!

ATB,
Ramsay Jones

  reply	other threads:[~2011-08-13 17:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05 16:10 [PATH 0/2] On Cygwin support both UNIX and DOS style path-names Pascal Obry
2011-08-05 16:10 ` [PATCH 1/2] git-compat-util: add generic find_last_dir_sep that respects is_dir_sep Pascal Obry
2011-08-05 16:10 ` [PATCH 2/2] On Cygwin support both UNIX and DOS style path-names Pascal Obry
2011-08-05 17:29   ` Erik Faye-Lund
2011-08-05 17:35     ` Pascal Obry
2011-08-05 17:39       ` Erik Faye-Lund
2011-08-05 17:51         ` Erik Faye-Lund
2011-08-05 18:39         ` Pascal Obry
2011-08-09 17:30       ` Ramsay Jones
2011-08-09 17:26     ` Ramsay Jones
2011-08-05 17:48   ` Junio C Hamano
2011-08-05 17:58     ` Erik Faye-Lund
2011-08-06  7:01     ` Pascal Obry
2011-08-09 17:24   ` Ramsay Jones
2011-08-09 20:38     ` Pascal Obry
2011-08-11 20:35       ` Ramsay Jones [this message]
2011-08-13 17:34         ` Pascal Obry
2011-08-10  2:44     ` Vijay Lakshminarayanan
2011-08-09 19:47   ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E443D1B.60306@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1$(echo .)demon.co.uk \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pascal@obry$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox