From: Johannes Sixt <j6t@kdbg•org>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] rebase -i: clean error message for --continue after failed exec
Date: Thu, 25 Aug 2011 15:04:27 +0200 [thread overview]
Message-ID: <4E56485B.10206@kdbg.org> (raw)
In-Reply-To: <vpqzkiydl21.fsf@bauges.imag.fr>
Am 25.08.2011 09:09, schrieb Matthieu Moy:
> Junio C Hamano<gitster@pobox•com> writes:
>> I wonder if doing something like this would be more direct approach to
>> achieve the same thing.
>
> Not the same thing, but both patches could go well together.
>
> Mine covers
>
> pick deadbeef
> exec make test
> # :-( make test failed, I'm going to fix it
> hack hack hack
> git add changes
> # OK, seems fixed.
> git rebase --continue
> # --> rebase tells me I forgot to commit my fixup patch
This is exactly my use-case that discovered the problem and which I would
like to see fixed, FWIW.
-- Hannes
next prev parent reply other threads:[~2011-08-25 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 21:11 rebase -i: Should --continue auto-amend after failed exec? Johannes Sixt
2011-08-24 13:36 ` Matthieu Moy
2011-08-24 14:01 ` [PATCH] rebase -i: clean error message for --continue after failed exec Matthieu Moy
2011-08-24 18:42 ` Junio C Hamano
2011-08-24 18:54 ` Junio C Hamano
2011-08-25 7:09 ` Matthieu Moy
2011-08-25 13:04 ` Johannes Sixt [this message]
2011-08-24 20:20 ` Jeff King
2011-08-24 20:22 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E56485B.10206@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox