From: Eric Sunshine <sunshine@sunshineco•com>
To: Jeff King <peff@peff•net>
Cc: Boaz Harrosh <bharrosh@panasas•com>, git@vger•kernel.org
Subject: Re: [RFC/PATCH] attr: map builtin userdiff drivers to well-known extensions
Date: Thu, 25 Aug 2011 19:44:25 -0400 [thread overview]
Message-ID: <4E56DE59.5050601@sunshineco.com> (raw)
In-Reply-To: <20110825210654.GA11077@sigill.intra.peff.net>
On 08/25/2011 05:06 PM, Jeff King wrote:
> On Thu, Aug 25, 2011 at 05:00:51PM -0400, Eric Sunshine wrote:
>
>>> Also, any other extensions that would go into such a list? I have no
>>> idea what the common extension is for something like pascal or csharp.
>>
>> C# uses extension ".cs".
>>
>> ".cpp" is common, in fact often required, by Windows compilers.
>
> Thanks, added both to my list.
To clarify, I meant to say that for C++, .cpp is common/required on Windows.
>> What about ".h" and ".hpp"?
>
> How well do our cpp patterns do with header files? I imagine they're
> better than the default, but I don't think I've ever really tried
> anything tricky.
I scanned through a number of revisions for one of my long-running C++
projects comparing the diff of header files with and without "*.h
diff=cpp". In some header files in this project, the oft-used C++
keywords public:, protected:, and private: appear at start-of-line. In
such cases, the default diff emits a less-than-useful hunk header:
@@ -19,8 +19,8 @@ public:
whereas, "diff=cpp" emits:
@@ -19,8 +19,8 @@ class Foobar
-- ES
next prev parent reply other threads:[~2011-08-25 23:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 19:14 git diff annoyance / feature request Boaz Harrosh
2011-08-25 20:00 ` Jeff King
2011-08-25 20:40 ` [RFC/PATCH] attr: map builtin userdiff drivers to well-known extensions Jeff King
2011-08-25 21:00 ` Eric Sunshine
2011-08-25 21:06 ` Jeff King
2011-08-25 22:01 ` Boaz Harrosh
2011-08-25 23:44 ` Eric Sunshine [this message]
2011-08-26 2:39 ` Jeff King
2011-08-25 22:29 ` Brandon Casey
2011-08-26 2:45 ` Jeff King
2011-08-26 3:58 ` Eric Sunshine
2011-08-26 15:33 ` Brandon Casey
2011-08-25 22:57 ` Junio C Hamano
2011-08-26 2:59 ` Jeff King
2011-08-26 5:52 ` Junio C Hamano
2011-08-26 9:44 ` Thomas Rast
2011-08-27 5:14 ` Alexey Shumkin
2011-08-25 20:27 ` git diff annoyance / feature request Junio C Hamano
2011-08-25 21:58 ` Boaz Harrosh
2011-08-26 9:08 ` Miles Bader
2011-08-26 21:16 ` René Scharfe
2011-08-26 21:37 ` Boaz Harrosh
2011-08-26 21:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E56DE59.5050601@sunshineco.com \
--to=sunshine@sunshineco$(echo .)com \
--cc=bharrosh@panasas$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox