From: Luke Diamand <luke@diamand•org>
To: "L. A. Linden Levy" <alevy@mobitv•com>
Cc: Vitor Antunes <vitor.hda@gmail•com>,
"git@vger•kernel.org" <git@vger•kernel.org>
Subject: Re: git-p4.skipSubmitEdit
Date: Sat, 10 Sep 2011 07:10:39 +0100 [thread overview]
Message-ID: <4E6AFF5F.6090805@diamand.org> (raw)
In-Reply-To: <1315590747.10046.5.camel@uncle-pecos>
On 09/09/11 18:52, L. A. Linden Levy wrote:
> I noticed that it only skipped the edit check. That is why I added the
> skipSubmitEdit option. If they are both true then it never opens the
> editor and never checks for an edit. Probably they should just be one
> option. I think it should probably also be a command line option to skip
> the editor.
Sounds plausible. If the skipSubmitEdit is true then the edit check
should always be skipped.
>
> - Alex
>
> On Fri, 2011-09-09 at 13:47 -0400, Luke Diamand wrote:
>> On 09/09/11 11:05, Vitor Antunes wrote:
>>> L. A. Linden Levy<alevy<at> mobitv.com> writes:
>>>
>>>>
>>>> Hi All,
>>>>
>>>> I have been using git-p4 for a while and it has allowed me to completely
>>>> change the way I develop and still be able to use perforce which my
>>>> company has for its main VCS. One thing that was driving me nuts was
>>>> that "git p4 submit" cycles through all of my individual commits and
>>>> asks me if I want to change them. The way I develop I often am checking
>>>> in 20 to 50 different small commits each with a descriptive git comment.
>>>> I felt like I was doing double duty by having emacs open on every commit
>>>> into perforce. So I modified git-p4 to have an option to skip the
>>>> editor. This option coupled with git-p4.skipSubmitEditCheck will make
>>>> the submission non-interactive for "git p4 submit".
>>>
>>> Hi Loren,
>>>
>>> This option was already included in a recent commit. The name that was
>>> used is "skipSubmitEditCheck". Please make sure you are using the most
>>> recent version of the script.
>>
>> I put that option in - glad it's of use!
>>
>> That option actually just skips the check of 'did the user edit the
>> file'. git-p4 will still go ahead and bring up the file in the editor first.
>>
>> I get around this myself by setting EDITOR=/bin/true. That works for me
>> because I'm only using it in a script.
>>
>> But it's possible that an additional option would actually be useful.
>>
>>
>>
>>>
>>> But don't let this discourage you from submitting patches. Just makesure
>>> you clone git's repository and apply your patch over "maint" or "master"
>>> branches. For more details on how to submit patches you can read
>>> Documentation/SubmittingPatches.
>>>
>>> Vitor
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe git" in
>>> the body of a message to majordomo@vger•kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
next prev parent reply other threads:[~2011-09-10 6:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 20:40 git-p4.skipSubmitEdit L. A. Linden Levy
2011-09-09 10:05 ` git-p4.skipSubmitEdit Vitor Antunes
2011-09-09 17:47 ` git-p4.skipSubmitEdit Luke Diamand
2011-09-09 17:52 ` git-p4.skipSubmitEdit L. A. Linden Levy
2011-09-10 6:10 ` Luke Diamand [this message]
2011-09-12 7:34 ` git-p4.skipSubmitEdit Luke Diamand
2011-09-12 17:12 ` git-p4.skipSubmitEdit L. A. Linden Levy
2011-10-18 0:45 ` git-p4.skipSubmitEdit Pete Wyckoff
2011-10-18 16:51 ` git-p4.skipSubmitEdit L. A. Linden Levy
2011-10-18 17:35 ` git-p4.skipSubmitEdit Pete Wyckoff
2011-10-18 17:53 ` git-p4.skipSubmitEdit Luke Diamand
2011-10-20 1:16 ` git-p4.skipSubmitEdit Pete Wyckoff
2011-12-16 15:38 ` git-p4.skipSubmitEdit Michael Horowitz
2011-12-16 19:50 ` git-p4.skipSubmitEdit Luke Diamand
2011-12-17 0:46 ` git-p4.skipSubmitEdit Michael Horowitz
2011-12-17 0:49 ` git-p4.skipSubmitEdit Michael Horowitz
2011-12-17 17:39 ` [PATCH] git-p4: fix skipSubmitEdit regression Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6AFF5F.6090805@diamand.org \
--to=luke@diamand$(echo .)org \
--cc=alevy@mobitv$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=vitor.hda@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox