From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>,
Sverre Rabbelier <srabbelier@gmail•com>,
GIT Mailing-list <git@vger•kernel.org>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: t5800-*.sh: Intermittent test failures
Date: Sun, 11 Sep 2011 20:14:36 +0100 [thread overview]
Message-ID: <4E6D089C.4090006@ramsay1.demon.co.uk> (raw)
In-Reply-To: <20110908182055.GA16500@sigill.intra.peff.net>
Jeff King wrote:
> On Thu, Sep 08, 2011 at 06:42:11PM +0100, Ramsay Jones wrote:
>
>> When I run the tests with "make test >test-out", I see a failure rate of about
>> 1 in 10. If I then set the debug environment variables (GIT_TRANSPORT_HELPER_DEBUG,
>> GIT_TRANSLOOP_DEBUG and GIT_DEBUG_TESTGIT) and run the test script directly (-v),
>> then the failure rate goes up to about 1 in 3.
>
> Hmm. I can't reproduce a failure here, but I do get some weirdness. My
> recipe is:
Ah, sorry, ... I didn't make myself clear then, because ...
> -- >8 --
> cat >foo.sh <<\EOF
> #!/bin/sh
>
> exec >$1.out 2>&1
>
> n=0
> while test $n -lt 100; do
> n=$(($n+1))
> GIT_TRANSPORT_HELPER_DEBUG=1 \
> GIT_TRANSLOOP_DEBUG=1 \
> GIT_DEBUG_TESTGIT=1 \
> ./t5800-remote-helpers.sh --root=/run/shm/git-tests-$1 -v || {
> echo FAIL $n
> exit 1
> }
> echo OK $n
> done
> EOF
>
> # try to keep an 8-core machine busy
> for i in `seq 1 16`; do
> sh foo.sh $i &
> done
> -- 8< --
>
> I never see a test failure, but a few of the 16 end up hanging. The
> process tree for the hanged tests look like:
>
> t5800-remote-helper
> git push
> git-remote-testgit
> git fast-import
> git-fast-import
>
> All of them are blocked on wait(), except for the final fast-import,
> which is blocked trying to read() from stdin.
... these hangs *are* the failures of which I speak! Yes, the script
doesn't get to declare a failure, but AFAIAC a hanging test (and it
isn't the same test # each time) is a failing test. :-D
ATB,
Ramsay Jones
next prev parent reply other threads:[~2011-09-11 19:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 18:30 t5800-*.sh: Intermittent test failures Ramsay Jones
2011-08-11 21:39 ` Sverre Rabbelier
2011-08-13 20:51 ` Ramsay Jones
2011-09-04 19:06 ` Junio C Hamano
2011-09-08 17:42 ` Ramsay Jones
2011-09-08 18:20 ` Jeff King
2011-09-11 19:14 ` Ramsay Jones [this message]
2011-11-01 21:57 ` Alex Riesen
2011-11-01 22:18 ` Junio C Hamano
2011-11-01 23:02 ` Alex Riesen
2011-11-02 23:35 ` Sverre Rabbelier
2011-11-03 1:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6D089C.4090006@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=srabbelier@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox