Subject: Re: [PATCH 6/6] Retain caches of submodule refs

From: Michael Haggerty <[email-masked]>
Date: Tue, 11 Oct 2011 06:12:34 +0200

On 10/10/2011 09:53 PM, Heiko Voigt wrote:
> On Sun, Oct 09, 2011 at 01:12:20PM +0200, Michael Haggerty wrote:
> Since the setup_revision() api can currently not be used to safely
> iterate twice over the same submodule my patch
> 
> 	allow multiple calls to submodule merge search for the same path
> 
> rewrites the search into using a child process. AFAIK the submodule ref
> iteration api would then even be unused.

If your patch is accepted, then we should check whether anything should
be ripped out.

> At least in my code there is no place where a submodule ref is changed.
> I only used it for merging submodule which only modifies the main
> module. So I would say its currently safe to assume that submodule refs
> do not get modified. If we do need that later on we can still add
> invalidation for submodule refs.

OK, thanks!

Michael

-- 
Michael Haggerty
[email-masked]
http://softwareswirl.blogspot.com/