public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Andrew Wong <andrew.w@sohovfx•com>
To: Neal Kreitzinger <neal@rsss•com>
Cc: git@vger•kernel.org
Subject: Re: rebase -i reword runs pre-commit hook with curious results
Date: Thu, 02 Feb 2012 00:43:34 -0500	[thread overview]
Message-ID: <4F2A2286.3090808@sohovfx.com> (raw)
In-Reply-To: <jgcc3q$mvl$1@dough.gmane.org>

On 12-02-01 4:50 PM, Neal Kreitzinger wrote:
> I'm confused on why and/or how interactive rebase runs the pre-commit hook
> when doing the reword command for commit (a).
When you do a "reword" in "rebase -i", it basically does a "cherry-pick" 
of that commit first, then it does a "commit --amend". And your 
pre-commit hook should've been run during the amend.
> IOW, the pre-commit hook does not get the same results as if I were doing a
> commandline git-commit of a modified index.
Does your pre-commit hook work when doing a "commit --amend"? I'm not 
sure if you can actually modify the author (or committer) date from 
inside a pre-commit hook.

  reply	other threads:[~2012-02-02  5:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 21:50 rebase -i reword runs pre-commit hook with curious results Neal Kreitzinger
2012-02-02  5:43 ` Andrew Wong [this message]
2012-02-02 16:39   ` Neal Kreitzinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2A2286.3090808@sohovfx.com \
    --to=andrew.w@sohovfx$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=neal@rsss$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox