Subject: Re: [PATCH] Convert isatty() calls to git_isatty()

From: Johannes Sixt <[email-masked]>
Date: Fri, 03 Feb 2012 10:48:59 +0100

Am 2/3/2012 9:35, schrieb Nguyễn Thái Ngọc Duy:
> isatty() is used to check for interactive use cases. However if pager is
> set up, standard file handles may be redirected and istty() calls later
> on no longer reflect the original state.

So what? What's wrong with this behavior?

You converted many cases involving progress indicators. Wouldn't the new
code pipe progress output to the pager where earlier it was not shown if a
pager was present? That is plainly wrong: Progress output is destined only
for the terminal, not for the pager.

-- Hannes