public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Rune Schjellerup Philosof <rune@philosof•dk>
To: git@vger•kernel.org
Subject: [PATCH 1/2] Complain in the tests about git config not failing with, keys without a section
Date: Fri, 02 Mar 2012 11:57:34 +0100	[thread overview]
Message-ID: <4F50A79E.5060206@philosof.dk> (raw)

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

From c4fc13a5a1e8c1eab9873232e6e8b7e0523cd6ea Mon Sep 17 00:00:00 2001
From: Rune Philosof <rune.git@philosof•dk>
Date: Fri, 2 Mar 2012 10:42:23 +0100
Subject: [PATCH 1/2] Complain in the tests about git config not failing with
 keys without a section

git is supposed to fail when having a key without a section, but does not.

Signed-off-by: Rune Philosof <rune.git@philosof•dk>
---
 t/t1300-repo-config.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index 5f249f6..81ccad5 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -928,6 +928,11 @@ test_expect_success 'git -c "key=value" support' '
 	test_must_fail git -c name=value config core.name
 '

+test_expect_failure 'No section' '
+	echo "fail=true" > failconf &&
+	test_must_fail git config --file failconf --list
+'
+
 test_expect_success 'key sanity-checking' '
 	test_must_fail git config foo=bar &&
 	test_must_fail git config foo=.bar &&
-- 
1.7.5.4


[-- Attachment #2: S/MIME-signeret meddelelse --]
[-- Type: application/pkcs7-signature, Size: 2033 bytes --]

             reply	other threads:[~2012-03-02 11:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 10:57 Rune Schjellerup Philosof [this message]
2012-03-02 18:40 ` [PATCH 1/2] Complain in the tests about git config not failing with, keys without a section Junio C Hamano
2012-03-05  7:59   ` Rune Philosof
2012-03-05 10:37     ` Jeff King
2012-03-05 19:29       ` Junio C Hamano
2012-03-06  8:06         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F50A79E.5060206@philosof.dk \
    --to=rune@philosof$(echo .)dk \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox