From: Nelson Benitez Leon <nelsonjesus.benitez@seap•minhap.es>
To: git@vger•kernel.org
Cc: peff@peff•net, sam@vilain•net
Subject: [PATCH v3 4/4] http: handle proxy authentication failure (error 407)
Date: Mon, 05 Mar 2012 16:21:28 +0100 [thread overview]
Message-ID: <4F54D9F8.2010401@seap.minhap.es> (raw)
Handle http 407 error code by asking for credentials and
retrying request in case credentials were not present, or
marking credentials as rejected if they were already provided.
Signed-off-by: Nelson Benitez Leon <nbenitezl@gmail•com>
---
http.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/http.c b/http.c
index b0b4362..5fffa47 100644
--- a/http.c
+++ b/http.c
@@ -812,6 +812,22 @@ static int http_request(const char *url, void *result, int target, int options)
init_curl_http_auth(slot->curl);
ret = HTTP_REAUTH;
}
+ } else if (results.http_code == 407) { /* Proxy authentication failure */
+ if (proxy_auth.username && proxy_auth.password) {
+ credential_reject(&proxy_auth);
+ ret = HTTP_NOAUTH;
+ } else {
+ struct strbuf pbuf = STRBUF_INIT;
+ credential_from_url(&proxy_auth, curl_http_proxy);
+ credential_fill(&proxy_auth);
+ strbuf_addf(&pbuf, "%s://%s:%s@%s",proxy_auth.protocol,
+ proxy_auth.username, proxy_auth.password,
+ proxy_auth.host);
+ free ((void *)curl_http_proxy);
+ curl_http_proxy = strbuf_detach(&pbuf, NULL);
+ curl_easy_setopt(slot->curl, CURLOPT_PROXY, curl_http_proxy);
+ ret = HTTP_REAUTH;
+ }
} else {
if (!curl_errorstr[0])
strlcpy(curl_errorstr,
--
1.7.7.6
next reply other threads:[~2012-03-05 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 15:21 Nelson Benitez Leon [this message]
2012-03-06 8:54 ` [PATCH v3 4/4] http: handle proxy authentication failure (error 407) Jeff King
2012-03-06 11:10 ` Nelson Benitez Leon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54D9F8.2010401@seap.minhap.es \
--to=nelsonjesus.benitez@seap$(echo .)minhap.es \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=sam@vilain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox