From: Nelson Benitez Leon <nelsonjesus.benitez@seap•minhap.es>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, peff@peff•net, sam@vilain•net
Subject: Re: [PATCH v2 1/3]http: authenticate on NTLM proxies and others suppported by CuRL
Date: Mon, 05 Mar 2012 16:33:16 +0100 [thread overview]
Message-ID: <4F54DCBC.6080307@seap.minhap.es> (raw)
In-Reply-To: <7v4nu6et1x.fsf@alter.siamese.dyndns.org>
On 03/02/2012 07:50 PM, Junio C Hamano wrote:
> Nelson Benitez Leon <nelsonjesus.benitez@seap•minhap.es> writes:
>
> Is there anything specific about NTLM in this patch? Let's retitle it to
> something like
>
> http: support proxies that needs authentication
>
>> ...
>> So as CURLAUTH_ANY provide us out-of-the-box proxy support, we don't
>> want it activated manually from a config option, instead we added it
>> automatically when a proxy is being used.
>
> I can sort of parse this paragraph but cannot follow the logic.
>
> - Because we use CURLAUTH_ANY, a proxy that requires authentication is
> supported out-of-the-box.
>
> - We do not want having to manually enable it.
>
> - Instead of adding a manual configuration, we do so automatically.
>
> It sounds like it is saying the same thing three times. Do we even need
> that paragraph? Shouldn't we drop it instead?
I've dropped it in v3 patchset.
>
> Otherwise it all looks good, so you can either
>
> (1) explain why the above suggestions are wrong and why I should apply
> the message I am responding to as-is;
>
> (2) send another re-roll; or
>
> (3) say "yeah, your suggestions all sound good to me", in which case I'll
> just locally amend and apply.
>
I've re-rolled a new patchset and included your suggestions about wording,
you're welcome to better fine-tune the messages and commit if you find them
suitable.
Thanks!
prev parent reply other threads:[~2012-03-05 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 18:19 [PATCH v2 1/3]http: authenticate on NTLM proxies and others suppported by CuRL Nelson Benitez Leon
2012-03-01 19:07 ` Junio C Hamano
2012-03-02 13:55 ` Nelson Benitez Leon
2012-03-02 18:50 ` Junio C Hamano
2012-03-05 15:33 ` Nelson Benitez Leon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54DCBC.6080307@seap.minhap.es \
--to=nelsonjesus.benitez@seap$(echo .)minhap.es \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sam@vilain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox