From: Nelson Benitez Leon <nelsonjesus.benitez@seap•minhap.es>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org, sam@vilain•net
Subject: Re: [PATCH v3 2/4] http: try http_proxy env var when http.proxy config option is not set
Date: Tue, 06 Mar 2012 15:08:47 +0100 [thread overview]
Message-ID: <4F561A6F.2040206@seap.minhap.es> (raw)
In-Reply-To: <20120306112745.GA6733@sigill.intra.peff.net>
On 03/06/2012 12:27 PM, Jeff King wrote:
> On Tue, Mar 06, 2012 at 01:22:46PM +0100, Nelson Benitez Leon wrote:
>
>>> Also I thought the conclusion from the other thread was that even if
>>> we were to do this, we should apply the http_proxy environment only
>>> when we are talking to http:// and for https:// we would instead
>>> read HTTPS_PROXY or something?
>>
>> Ok I completely miss this, can this be added in a later patch?
>
> Hmm. Your current series munges the curl_http_proxy variable in order to
> put the username and password in, and therefore needs to know what is in
> the proxy variable.
>
> But if you switch patch 4/4 to set CURLOPT_PROXYUSERPWD, then we won't
> need to care what's in curl_http_proxy, no? We will get a 407 from curl
> because curl detected the proxy (either from the environment, or because
> we actually told it via curl_http_proxy), and then we will fill in the
> username and password without touching the actual proxy URL.
>
> So this patch can just be dropped at that point, right?
I think so, I will try 4/4 using proxyuserpwd.
next prev parent reply other threads:[~2012-03-06 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 15:17 [PATCH v3 2/4] http: try http_proxy env var when http.proxy config option is not set Nelson Benitez Leon
2012-03-05 17:30 ` Junio C Hamano
2012-03-06 12:22 ` Nelson Benitez Leon
2012-03-06 11:27 ` Jeff King
2012-03-06 14:08 ` Nelson Benitez Leon [this message]
2012-03-06 15:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F561A6F.2040206@seap.minhap.es \
--to=nelsonjesus.benitez@seap$(echo .)minhap.es \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sam@vilain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox