From: Ivan Todoroski <grnch@gmx•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option
Date: Tue, 03 Apr 2012 02:23:32 +0200 [thread overview]
Message-ID: <4F7A4304.9040800@gmx.net> (raw)
In-Reply-To: <7v4nt2exlr.fsf@alter.siamese.dyndns.org>
On 02.04.2012 21:34, Junio C Hamano wrote:
> Ivan Todoroski <grnch@gmx•net> writes:
>
>> +test_expect_success 'setup tests for the --stdin parameter' '
>> + for head in C D E F
>> + do
>> + add $head
>> + done &&
>> + for head in A B C D E F
>> + do
>> + git tag $head $head
>> + done
>> + cat >input <<EOF
>> +refs/heads/C
>> +refs/heads/A
>> +refs/heads/D
>> +refs/tags/C
>> +refs/heads/B
>> +refs/tags/A
>> +refs/heads/E
>> +refs/tags/B
>> +refs/tags/E
>> +refs/tags/D
>> +EOF
>> + sort <input >expect
>> + (
>> + echo refs/heads/E &&
>> + echo refs/tags/E &&
>> + cat input
>> + ) >input.dup
>> +'
>
>
> This breaks && chain; also it is easier to read if indentation is used
> properly.
>
> I'll queue it after fixing the above locally (the rest looked OK to me).
>
> Thanks.
I just saw the neat <<- trick in your reworked version, nice! Somehow
I've never stumbled on to that part of the bash man page before. :|
When I look back how many shell scripts I've mangled with indentation
like above, it breaks my heart. :)
next prev parent reply other threads:[~2012-04-03 0:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 15:11 [PATCH v3 0/4] Clone fails on a repo with too many heads/tags Ivan Todoroski
2012-04-02 15:13 ` [PATCH v3 1/4] fetch-pack: new --stdin option to read refs from stdin Ivan Todoroski
2012-04-02 20:42 ` Jeff King
2012-04-02 15:14 ` [PATCH v3 2/4] remote-curl: send the refs to fetch-pack on stdin Ivan Todoroski
2012-04-02 18:50 ` Junio C Hamano
2012-04-02 15:16 ` [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option Ivan Todoroski
2012-04-02 19:34 ` Junio C Hamano
2012-04-03 0:23 ` Ivan Todoroski [this message]
2012-04-02 15:17 ` [PATCH v3 4/4] remote-curl: main test case for the OS command line overflow Ivan Todoroski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7A4304.9040800@gmx.net \
--to=grnch@gmx$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox