From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Johannes Sixt <j.sixt@viscovery•net>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>,
"Junio C Hamano" <gitster@pobox•com>,
"Git Mailing List" <git@vger•kernel.org>
Subject: Re: What's cooking in git.git (Apr 2012, #06; Sun, 15)
Date: Wed, 18 Apr 2012 20:53:37 +0100 [thread overview]
Message-ID: <4F8F1BC1.3030607@ramsay1.demon.co.uk> (raw)
In-Reply-To: <4F8E6A12.9090708@viscovery.net>
Johannes Sixt wrote:
> Am 4/16/2012 8:44, schrieb Junio C Hamano:
>> * nd/threaded-index-pack (2012-04-11) 3 commits
>> - index-pack: support multithreaded delta resolving
>> - index-pack: split second pass obj handling into own function
>> - compat/win32/pthread.h: Add an pthread_key_delete() implementation
>
> With this series, t9300.92 (fast-import, Q: verify pack) consistently
> fails for me on Windows.
>
> I'll have to see when I can dig deeper into this topic...
Hmm, this works just fine for me.
[I know that doesn't help you much :(, but it at least provides another
data-point.]
With the exception of t9300.62 (a fix for which I have already sent to
the list), all of the following tests pass:
t/t5300-pack-object.sh
t/t5301-sliding-window.sh
t/t5302-pack-index.sh
t/t5303-pack-corruption-resilience.sh
t/t5510-fetch.sh
t/t6050-replace.sh
t/t7700-repack.sh
t/t7701-repack-unpack-unreachable.sh
t/t9300-fast-import.sh
Just to be clear, I have to apply a patch (given below) to pu in order to
do any meaningful testing. This patch is the one I had ready to send to the
list to fix the SHELL_PATH breakage, but you beat me to the punch! :-P
(Also, your commit message was *much* better than mine!)
[my MinGW was installed from msysGit-fullinstall-1.7.4-preview20110204.exe
on Windows XP SP3]
ATB,
Ramsay Jones
--- >8 ---
diff --git a/run-command.c b/run-command.c
index 5be1b4b..53a081b 100644
--- a/run-command.c
+++ b/run-command.c
@@ -4,7 +4,10 @@
#include "sigchain.h"
#include "argv-array.h"
-#ifndef SHELL_PATH
+#if defined(WIN32)
+# undef SHELL_PATH
+# define SHELL_PATH "sh"
+#elif !defined(SHELL_PATH)
# define SHELL_PATH "/bin/sh"
#endif
--- 8< ---
next prev parent reply other threads:[~2012-04-18 20:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 6:44 What's cooking in git.git (Apr 2012, #06; Sun, 15) Junio C Hamano
2012-04-16 9:07 ` Nelson Benitez Leon
2012-04-16 8:20 ` Junio C Hamano
2012-04-16 11:24 ` Nelson Benitez Leon
2012-04-16 15:03 ` Junio C Hamano
2012-04-18 7:15 ` Johannes Sixt
2012-04-18 19:53 ` Ramsay Jones [this message]
2012-04-19 6:16 ` Johannes Sixt
2012-04-19 6:45 ` Johannes Sixt
2012-04-19 7:02 ` Nguyen Thai Ngoc Duy
2012-04-19 9:36 ` Nguyen Thai Ngoc Duy
2012-04-19 12:58 ` Erik Faye-Lund
2012-04-19 13:18 ` Nguyen Thai Ngoc Duy
2012-04-19 13:31 ` Erik Faye-Lund
2012-04-19 13:38 ` Nguyen Thai Ngoc Duy
2012-04-19 13:48 ` Johannes Sixt
2012-04-19 13:52 ` Erik Faye-Lund
2012-04-21 3:00 ` Nguyen Thai Ngoc Duy
2012-04-21 5:46 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F1BC1.3030607@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j.sixt@viscovery$(echo .)net \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox