Subject: Re: [PATCH 2/2] cmd_fetch_pack(): fix constness problem and memory leak

From: Michael Haggerty <[email-masked]>
Date: Wed, 02 May 2012 15:35:49 +0200

On 05/02/2012 01:14 PM, Nguyen Thai Ngoc Duy wrote:
> On Wed, May 2, 2012 at 5:40 PM,<[email-masked]>  wrote:
>>                 const char *arg = argv[i];
>>
>> -               if (*arg == '-') {
>> -                       if (!prefixcmp(arg, "--upload-pack=")) {
>> -                               args.uploadpack = arg + 14;
>> -                               continue;
>> -                       }
>> [...]
> Ugh, perhaps you can convert the above to parse_options() too while
> you're making changes in this part? You can say no, I'll do it (my
> itch anyway).

Sorry, I have too many balls in the air already.  But feel free to veto 
my patch if my changes make it harder to switch to parse_options().

Michael

-- 
Michael Haggerty
[email-masked]
http://softwareswirl.blogspot.com/