public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Junio C Hamano <gitster@pobox•com>
Cc: rene.scharfe@lsrfire•ath.cx, GIT Mailing-list <git@vger•kernel.org>
Subject: [PATCH] builtin/blame.c: Fix a "Using plain integer as NULL pointer" warning
Date: Sun, 13 May 2012 22:41:16 +0100	[thread overview]
Message-ID: <4FB02A7C.1000605@ramsay1.demon.co.uk> (raw)



Signed-off-by: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
---

Hi Junio,

I try to catch these warnings, while the topics are still in the
pu branch, so that we can squash the fix into them before they
hit next. I don't know how I missed this one (commit 4b4132f,
"blame: factor out helper for calling xdi_diff()", 09-05-2012)
which was part of the 'rs/xdiff-lose-emit-func' branch.

Sorry about that.

ATB,
Ramsay Jones


 builtin/blame.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/blame.c b/builtin/blame.c
index 778d661..24d3dd5 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -93,7 +93,7 @@ static int diff_hunks(mmfile_t *file_a, mmfile_t *file_b, long ctxlen,
 {
 	xpparam_t xpp = {0};
 	xdemitconf_t xecfg = {0};
-	xdemitcb_t ecb = {0};
+	xdemitcb_t ecb = {NULL};
 
 	xpp.flags = xdl_opts;
 	xecfg.ctxlen = ctxlen;
-- 
1.7.10

next             reply	other threads:[~2012-05-13 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 21:41 Ramsay Jones [this message]
2012-05-13 23:39 ` [PATCH] builtin/blame.c: Fix a "Using plain integer as NULL pointer" warning René Scharfe
2012-05-15 17:33   ` Ramsay Jones

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:778d661 dfblob:24d3dd5 )
 OR (
bs:"[PATCH] builtin/blame.c: Fix a "
bs:"Using plain integer as NULL pointer"
bs:" warning" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB02A7C.1000605@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1$(echo .)demon.co.uk \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=rene.scharfe@lsrfire$(echo .)ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox