Subject: [RFC] Deal with HTTP 401 by requesting credentials.

From: Kevin Stange <[email-masked]>
Date: Thu, 31 May 2012 17:24:55 -0500

Request credentials from the user if none are already defined when a
HTTP 401 is received on a restricted repository.  Then, resubmit the
request and return the final result.

This allows all webdav transactions to obtain credentials without having
to individually handle the case in each request.  Having push working
with HTTP auth is needed for a use case I have where storing the
credentials in .netrc or using SSH keys is inappropriate.

Apologies for anything wrong I might have done here.  I'm not used to
procedures for this sort of patch submission, or terribly familiar with
the code base.  I'm seeking advice on whether this approach is sane or
completely crazy, and I'm willing to adjust it to make it suitable for
inclusion.

Signed-off-by: Kevin <[email-masked]>
---
 http.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/http.c b/http.c
index 5cb87f1..e1c9e65 100644
--- a/http.c
+++ b/http.c
@@ -668,6 +668,21 @@ void finish_active_slot(struct active_request_slot
*slot)
 	closedown_active_slot(slot);
 	curl_easy_getinfo(slot->curl, CURLINFO_HTTP_CODE, &slot->http_code);

+	if (slot->http_code == 401) {
+		if(!http_auth.username && !http_auth.password) {
+			active_requests++;
+			credential_fill(&http_auth);
+			init_curl_http_auth(slot->curl);
+			(*slot->finished) = 1;
+			if (start_active_slot(slot)) {
+				run_active_slot(slot);
+				return;
+			}
+		} else {
+			fprintf(stderr,"Authentication Failed!\n");
+		}
+	}
+
 	if (slot->finished != NULL)
 		(*slot->finished) = 1;

-- 
1.7.11.rc0.55.gb2478aa

-- 
Kevin Stange
Chief Technology Officer
Steadfast Networks
http://steadfast.net
Phone: 312-602-2689 ext. 203 | Fax: 312-602-2688 | Cell: 312-320-5867