Subject: Re: [PATCHv3 3/6] Test file for git-remote-mediawiki clone

From: "Simon.Cathebras" <[email-masked]>
Date: Tue, 12 Jun 2012 15:58:48 +0200

On 11/06/2012 23:07, [email-masked] wrote:
>
> Simon Cathebras <[email-masked]> a écrit :
>
>
>> +test_expect_success 'Git clone creates the git log expected with one 
>> file' '
>> +    wiki_reset &&
>> +    cd '"$TRASH_DIR"' &&
>> +    rm -rf mw_dir &&
>> +    wiki_editpage foo "this is not important" false -c cat -s "this 
>> must be the same" &&
>> +    git clone mediawiki::http://localhost/wiki mw_dir &&
>> +    cd mw_dir &&
>> +    git log --format=%s HEAD^..HEAD > log.tmp &&
>> +    echo "this must be the same" > msg.tmp &&
>> +    diff -b log.tmp msg.tmp &&
>> +    cd .. &&
>> +    rm -rf mw_dir
>> +'
>> +
>
> It's best not to chdir around outside a subshell (same comment for all 
> the
> other tests)

Thanks, we managed to change these problems of chdir.

>
> BTW, please be aware of the whitespaces (the first 5 parts of your 
> patch are
> full of it - couldn't apply the last one because of the special 
> characters, maybe
> something that i haven't configure, i don't know).
>
>
Got it. We modified this issue with whitespaces.
In addition, we know what prevented you to install the last patch: 
encoding problem. It will be fixed in the next update.

Simon

-- 
CATHEBRAS Simon

2A-ENSIMAG

Filière Ingéniérie des Systèmes d'Information
Membre Bug-Buster